Changeset 201817 in webkit

Timestamp:

Jun 8, 2016 11:45:47 AM (8 years ago)

Author:

peavo@outlook.com

Message:

[Win] Shadow DOM tests are failing.
​https://bugs.webkit.org/show_bug.cgi?id=158524

Reviewed by Brent Fulgham.

.:

Enable Shadow DOM.

• Source/cmake/OptionsWin.cmake:

Source/WebKit/win:

Add preference for enabling Shadow DOM.

• Interfaces/IWebPreferencesPrivate.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::shadowDOMEnabled):
(WebPreferences::setShadowDOMEnabled):

• WebPreferences.h:
• WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

Enable Shadow DOM when running tests.

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

LayoutTests:

Update test expectations for Shadow DOM.

• platform/win/TestExpectations:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/win/TestExpectations (modified) (1 diff)
• Source/WebKit/win/ChangeLog (modified) (1 diff)
• Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (modified) (1 diff)
• Source/WebKit/win/WebPreferenceKeysPrivate.h (modified) (1 diff)
• Source/WebKit/win/WebPreferences.cpp (modified) (2 diffs)
• Source/WebKit/win/WebPreferences.h (modified) (1 diff)
• Source/WebKit/win/WebView.cpp (modified) (1 diff)
• Source/cmake/OptionsWin.cmake (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/win/DumpRenderTree.cpp (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2016-06-08  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] Shadow DOM tests are failing.
+        https://bugs.webkit.org/show_bug.cgi?id=158524
+
+        Reviewed by Brent Fulgham.
+
+        Enable Shadow DOM.
+
+        * Source/cmake/OptionsWin.cmake:
+
 2016-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-08  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] Shadow DOM tests are failing.
+        https://bugs.webkit.org/show_bug.cgi?id=158524
+
+        Reviewed by Brent Fulgham.
+
+        Update test expectations for Shadow DOM.
+
+        * platform/win/TestExpectations:
+
 2016-06-08  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
 

trunk/LayoutTests/platform/win/TestExpectations

@@ -3359 +3359 @@
 webkit.org/b/152411 http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html [ Failure ]
 
-webkit.org/b/153772 fast/shadow-dom/slot-removal-crash-2.html [ Timeout ]
+webkit.org/b/148695 fast/shadow-dom [ Pass ]
+
+# Touch events is not enabled on Windows
+webkit.org/b/149592 fast/shadow-dom/touch-event-ios.html [ Failure ]
 
 # The SVG -> OTF Font converter outputs 'kern' tables instead of 'GPOS' tables.

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2016-06-08  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] Shadow DOM tests are failing.
+        https://bugs.webkit.org/show_bug.cgi?id=158524
+
+        Reviewed by Brent Fulgham.
+
+        Add preference for enabling Shadow DOM.
+
+        * Interfaces/IWebPreferencesPrivate.idl:
+        * WebPreferenceKeysPrivate.h:
+        * WebPreferences.cpp:
+        (WebPreferences::initializeDefaultSettings):
+        (WebPreferences::shadowDOMEnabled):
+        (WebPreferences::setShadowDOMEnabled):
+        * WebPreferences.h:
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl

@@ -178 +178 @@
     HRESULT fetchAPIEnabled([out, retval] BOOL* enabled);
     HRESULT setFetchAPIEnabled([in] BOOL enabled);
+    HRESULT shadowDOMEnabled([out, retval] BOOL* enabled);
+    HRESULT setShadowDOMEnabled([in] BOOL enabled);
 }
 

trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h

@@ -171 +171 @@
 #define WebKitFetchAPIEnabledPreferenceKey "WebKitFetchAPIEnabled"
 
+#define WebKitShadowDOMEnabledPreferenceKey "WebKitShadowDOMEnabled"

trunk/Source/WebKit/win/WebPreferences.cpp

@@ -294 +294 @@
     CFDictionaryAddValue(defaults, CFSTR(WebKitFetchAPIEnabledPreferenceKey), kCFBooleanFalse);
 
+    CFDictionaryAddValue(defaults, CFSTR(WebKitShadowDOMEnabledPreferenceKey), kCFBooleanFalse);
+
     defaultSettings = defaults;
 }
@@ -1934 +1936 @@
     return S_OK;
 }
+
+HRESULT WebPreferences::shadowDOMEnabled(_Out_ BOOL* enabled)
+{
+    if (!enabled)
+        return E_POINTER;
+    *enabled = boolValueForKey(WebKitShadowDOMEnabledPreferenceKey);
+    return S_OK;
+}
+
+HRESULT WebPreferences::setShadowDOMEnabled(BOOL enabled)
+{
+    setBoolValue(WebKitShadowDOMEnabledPreferenceKey, enabled);
+    return S_OK;
+}

trunk/Source/WebKit/win/WebPreferences.h

@@ -236 +236 @@
     virtual HRESULT STDMETHODCALLTYPE fetchAPIEnabled(_Out_ BOOL*);
     virtual HRESULT STDMETHODCALLTYPE setFetchAPIEnabled(BOOL);
+    virtual HRESULT STDMETHODCALLTYPE shadowDOMEnabled(_Out_ BOOL*);
+    virtual HRESULT STDMETHODCALLTYPE setShadowDOMEnabled(BOOL);
 
     // WebPreferences

trunk/Source/WebKit/win/WebView.cpp

@@ -5047 +5047 @@
 #endif
 
+#if ENABLE(SHADOW_DOM)
+    hr = prefsPrivate->shadowDOMEnabled(&enabled);
+    if (FAILED(hr))
+        return hr;
+    RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(!!enabled);
+#endif
+
     hr = preferences->privateBrowsingEnabled(&enabled);
     if (FAILED(hr))

trunk/Source/cmake/OptionsWin.cmake

@@ -59 +59 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_CONTENT_UTILS PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REQUEST_ANIMATION_FRAME PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHADOW_DOM PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHADOW_DOM PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_STREAMS_API PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SVG_FONTS PUBLIC ON)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-06-08  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] Shadow DOM tests are failing.
+        https://bugs.webkit.org/show_bug.cgi?id=158524
+
+        Reviewed by Brent Fulgham.
+
+        Enable Shadow DOM when running tests.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (resetWebPreferencesToConsistentValues):
+
 2016-06-08  Lucas Forschler  <lforschler@apple.com>
 

trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp

@@ -851 +851 @@
     ASSERT(prefsPrivate3);
     prefsPrivate3->setFetchAPIEnabled(TRUE);
+    prefsPrivate3->setShadowDOMEnabled(TRUE);
 
     setAlwaysAcceptCookies(false);