Changeset 202075 in webkit

Timestamp:

Jun 14, 2016 6:03:30 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Inline media controls cut off PiP and fullscreen buttons on cnn.com
​https://bugs.webkit.org/show_bug.cgi?id=158766
<rdar://problem/24175161>

Patch by Antoine Quint <Antoine Quint> on 2016-06-14
Reviewed by Dean Jackson.

The display of the picture-in-picture and fullscreen buttons are dependent on the availability
of video tracks through a call to hasVideo(). We need to ensure that the display properties of
both those buttons are updated when the number of video tracks has changed since the controls
may be populated prior to the availability of video tracks.

• Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.updateHasVideo):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediacontrols/mediaControlsApple.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-14  Antoine Quint  <graouts@apple.com>
+
+        Inline media controls cut off PiP and fullscreen buttons on cnn.com
+        https://bugs.webkit.org/show_bug.cgi?id=158766
+        <rdar://problem/24175161>
+
+        Reviewed by Dean Jackson.
+
+        The display of the picture-in-picture and fullscreen buttons are dependent on the availability
+        of video tracks through a call to hasVideo(). We need to ensure that the display properties of
+        both those buttons are updated when the number of video tracks has changed since the controls
+        may be populated prior to the availability of video tracks.
+
+        * Modules/mediacontrols/mediaControlsApple.js:
+        (Controller.prototype.updateHasVideo):
+
 2016-06-14  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js

@@ -2036 +2036 @@
     updateHasVideo: function()
     {
-        if (this.hasVideo())
-            this.controls.panel.classList.remove(this.ClassNames.noVideo);
-        else
-            this.controls.panel.classList.add(this.ClassNames.noVideo);
+        this.controls.panel.classList.toggle(this.ClassNames.noVideo, !this.hasVideo());
+        // The availability of the picture-in-picture button as well as the full-screen
+        // button depends no the value returned by hasVideo(), so make sure we invalidate
+        // the availability of both controls.
+        this.updateFullscreenButtons();
     },