Changeset 202211 in webkit


Ignore:
Timestamp:
Jun 19, 2016 10:51:51 AM (8 years ago)
Author:
youenn.fablet@crf.canon.fr
Message:

The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
https://bugs.webkit.org/show_bug.cgi?id=158834

Reviewed by Eric Carlson.

No change of behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Explicitly setting DOMWrapped type definition from
JSXX class deriving from another JSYY class.

  • bindings/scripts/test/JS/JSTestEventTarget.h: Rebased.
  • bindings/scripts/test/JS/JSTestNode.h: Ditto.
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r202198 r202211  
     12016-06-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
     2
     3        The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
     4        https://bugs.webkit.org/show_bug.cgi?id=158834
     5
     6        Reviewed by Eric Carlson.
     7
     8        No change of behavior.
     9
     10        * bindings/scripts/CodeGeneratorJS.pm:
     11        (GenerateHeader): Explicitly setting DOMWrapped type definition from
     12        JSXX class deriving from another JSYY class.
     13        * bindings/scripts/test/JS/JSTestEventTarget.h: Rebased.
     14        * bindings/scripts/test/JS/JSTestNode.h: Ditto.
     15
    1162016-06-18  Antti Koivisto  <antti@apple.com>
    217
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r202105 r202211  
    11051105    push(@headerContent, "public:\n");
    11061106    push(@headerContent, "    typedef $parentClassName Base;\n");
     1107    push(@headerContent, "    typedef $implType DOMWrapped;\n") if $interface->parent;
     1108
    11071109    if ($interfaceName eq "DOMWindow") {
    11081110        push(@headerContent, "    static $className* create(JSC::VM& vm, JSC::Structure* structure, Ref<$implType>&& impl, JSDOMWindowShell* windowShell)\n");
  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h

    r200934 r202211  
    2929public:
    3030    typedef JSEventTarget Base;
     31    typedef TestEventTarget DOMWrapped;
    3132    static JSTestEventTarget* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, Ref<TestEventTarget>&& impl)
    3233    {
  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h

    r201128 r202211  
    2929public:
    3030    typedef JSNode Base;
     31    typedef TestNode DOMWrapped;
    3132    static JSTestNode* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, Ref<TestNode>&& impl)
    3233    {
Note: See TracChangeset for help on using the changeset viewer.