Changeset 202316 in webkit


Ignore:
Timestamp:
Jun 21, 2016 8:16:14 PM (8 years ago)
Author:
Chris Dumez
Message:

Unreviewed, rolling out r202296.

Broke basic browsing in Safari

Reverted changeset:

"WKWebView with no WKNavigationDelegate does not follow
universal links"
​https://bugs.webkit.org/show_bug.cgi?id=158997
​http://trac.webkit.org/changeset/202296

Location:
trunk
Files:
1 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r202308 r202316  
     12016-06-21  Chris Dumez  <cdumez@apple.com>
     2
     3        Unreviewed, rolling out r202296.
     4
     5        Broke basic browsing in Safari
     6
     7        Reverted changeset:
     8
     9        "WKWebView with no WKNavigationDelegate does not follow
     10        universal links"
     11        https://bugs.webkit.org/show_bug.cgi?id=158997
     12        http://trac.webkit.org/changeset/202296
     13
    1142016-06-21  Anders Carlsson  <andersca@apple.com>
    215

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

    r202296 r202316  
    543543
    544544    _navigationState = std::make_unique<WebKit::NavigationState>(self);
    545     _page->setNavigationClient(_navigationState->createNavigationClient());
    546 
    547545    _uiDelegate = std::make_unique<WebKit::UIDelegate>(self);
    548546    _page->setFindClient(std::make_unique<WebKit::FindClient>(self));

  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r202296 r202316  
    570570void WebPageProxy::setLoaderClient(std::unique_ptr<API::LoaderClient> loaderClient)
    571571{
    572     if (m_navigationClient && loaderClient)
    573         m_navigationClient = nullptr;
    574 
    575572    if (!loaderClient) {
    576573        m_loaderClient = std::make_unique<API::LoaderClient>();

  • trunk/Tools/ChangeLog

    r202308 r202316  
     12016-06-21  Chris Dumez  <cdumez@apple.com>
     2
     3        Unreviewed, rolling out r202296.
     4
     5        Broke basic browsing in Safari
     6
     7        Reverted changeset:
     8
     9        "WKWebView with no WKNavigationDelegate does not follow
     10        universal links"
     11        https://bugs.webkit.org/show_bug.cgi?id=158997
     12        http://trac.webkit.org/changeset/202296
     13
    1142016-06-21  Anders Carlsson  <andersca@apple.com>
    215

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r202296 r202316  
    101101                7C3965061CDD74F90094DBB8 /* Color.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7C3965051CDD74F90094DBB8 /* Color.cpp */; };
    102102                7C3DB8E41D12129B00AE8CC3 /* CommandBackForward.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7C3DB8E21D12129B00AE8CC3 /* CommandBackForward.mm */; };
    103                 7C417F331D19E14800B8EF53 /* WKWebViewDefaultNavigationDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7C417F311D19E14800B8EF53 /* WKWebViewDefaultNavigationDelegate.mm */; };
    104103                7C486BA11AA12567003F6F9B /* bundle-file.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 7C486BA01AA1254B003F6F9B /* bundle-file.html */; };
    105104                7C54A4BE1AA11CCA00380F78 /* WKBundleFileHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7C54A4BC1AA11CCA00380F78 /* WKBundleFileHandle.cpp */; };
    … …  
    754753                7C3965051CDD74F90094DBB8 /* Color.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Color.cpp; sourceTree = "<group>"; };
    755754                7C3DB8E21D12129B00AE8CC3 /* CommandBackForward.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = CommandBackForward.mm; sourceTree = "<group>"; };
    756                 7C417F311D19E14800B8EF53 /* WKWebViewDefaultNavigationDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKWebViewDefaultNavigationDelegate.mm; sourceTree = "<group>"; };
    757755                7C486BA01AA1254B003F6F9B /* bundle-file.html */ = {isa = PBXFileReference; lastKnownFileType = text.html; path = "bundle-file.html"; sourceTree = "<group>"; };
    758756                7C54A4BC1AA11CCA00380F78 /* WKBundleFileHandle.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WKBundleFileHandle.cpp; sourceTree = "<group>"; };
    … …  
    11691167                                93E943F11CD3E87E00AC08C2 /* VideoControlsManager.mm */,
    11701168                                2D00065D1C1F58940088E6A7 /* WKPDFViewResizeCrash.mm */,
    1171                                 7C417F311D19E14800B8EF53 /* WKWebViewDefaultNavigationDelegate.mm */,
    11721169                                0F3B94A51A77266C00DE3272 /* WKWebViewEvaluateJavaScript.mm */,
    11731170                                9984FACA1CFFAEEE008D198C /* WKWebViewTextInput.mm */,
    … …  
    21032100                                7CCE7EAF1A411A3800447C4C /* PlatformUtilities.cpp in Sources */,
    21042101                                0F139E781A423A6B00F590F5 /* PlatformUtilitiesCocoa.mm in Sources */,
    2105                                 7C417F331D19E14800B8EF53 /* WKWebViewDefaultNavigationDelegate.mm in Sources */,
    21062102                                7CCE7EA61A411A0F00447C4C /* PlatformUtilitiesMac.mm in Sources */,
    21072103                                7CCE7EA71A411A1300447C4C /* PlatformWebViewMac.mm in Sources */,
Note: See TracChangeset for help on using the changeset viewer.