Changeset 202323 in webkit


Ignore:
Timestamp:
Jun 21, 2016 10:47:58 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

[Fetch API] Rename 'origin-only' referrer policy to 'origin'
​https://bugs.webkit.org/show_bug.cgi?id=158982

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-06-21
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Renaming origin-only to origin.

  • web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
  • web-platform-tests/fetch/api/request/request-clone.sub.html:
  • web-platform-tests/fetch/api/request/request-idl.html:
  • web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
  • web-platform-tests/fetch/api/request/request-init-001.sub.html:
  • web-platform-tests/fetch/api/request/request-init-003.sub.html:

Source/WebCore:

Covered by updated tests.

  • Modules/fetch/FetchRequest.cpp:

(WebCore::setReferrerPolicy): Renaming origin-only to origin.

  • Modules/fetch/FetchRequest.idl: Ditto.
  • loader/FetchOptions.h: Ditto.
Location:
trunk
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r202245 r202323  
     12016-06-21  Youenn Fablet  <youennf@gmail.com>
     2
     3        [Fetch API] Rename 'origin-only' referrer policy to 'origin'
     4        https://bugs.webkit.org/show_bug.cgi?id=158982
     5
     6        Reviewed by Alex Christensen.
     7
     8        Renaming origin-only to origin.
     9
     10        * web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
     11        * web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
     12        * web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
     13        * web-platform-tests/fetch/api/request/request-clone.sub.html:
     14        * web-platform-tests/fetch/api/request/request-idl.html:
     15        * web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
     16        * web-platform-tests/fetch/api/request/request-init-001.sub.html:
     17        * web-platform-tests/fetch/api/request/request-init-003.sub.html:
     18
    1192016-06-20  Benjamin Poulain  <benjamin@webkit.org>
    220

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt

    r200195 r202323  
    22PASS Referrer policy: no-referrer
    33PASS Referrer policy: ""
    4 PASS Referrer policy: origin-only
     4PASS Referrer policy: origin
    55PASS Referrer policy: origin-when-cross-origin
    66PASS Referrer policy: unsafe-url

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt

    r200195 r202323  
    22PASS Referrer policy: no-referrer
    33PASS Referrer policy: ""
    4 PASS Referrer policy: origin-only
     4PASS Referrer policy: origin
    55PASS Referrer policy: origin-when-cross-origin
    66PASS Referrer policy: unsafe-url

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.js

    r200195 r202323  
    3333corsPreflightReferrer("Referrer policy: no-referrer", corsUrl, "no-referrer", "");
    3434corsPreflightReferrer("Referrer policy: \"\"", corsUrl, "", "");
    35 corsPreflightReferrer("Referrer policy: origin-only", corsUrl, "origin-only", origin);
     35corsPreflightReferrer("Referrer policy: origin", corsUrl, "origin", origin);
    3636corsPreflightReferrer("Referrer policy: origin-when-cross-origin", corsUrl, "origin-when-cross-origin", origin);
    3737corsPreflightReferrer("Referrer policy: unsafe-url", corsUrl, "unsafe-url", location.toString());

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html

    r197162 r202323  
    1717      var initValuesDict = {"method" : "POST",
    1818                            "referrer" : "http://{{host}}:{{ports[http][0]}}/",
    19                             "referrerPolicy" : "origin-only",
     19                            "referrerPolicy" : "origin",
    2020                            "mode" : "same-origin",
    2121                            "credentials" : "include",
    … …  
    2929      var expectedInitialized = {"method" : "POST",
    3030                                 "referrer" : "http://{{host}}:{{ports[http][0]}}/",
    31                                  "referrerPolicy" : "origin-only",
     31                                 "referrerPolicy" : "origin",
    3232                                 "mode" : "same-origin",
    3333                                 "credentials" : "include",

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html

    r198888 r202323  
    7171      enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache", "only-if-cached" };
    7272      enum RequestRedirect { "follow", "error", "manual" };
    73       enum ReferrerPolicy { "", "no-referrer", "no-referrer-when-downgrade", "origin-only", "origin-when-cross-origin", "unsafe-url" };
     73      enum ReferrerPolicy { "", "no-referrer", "no-referrer-when-downgrade", "origin", "origin-when-cross-origin", "unsafe-url" };
    7474    </script>
    7575    <script>

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt

    r197162 r202323  
    1515PASS Check referrerPolicy init value of no-referrer and associated getter
    1616PASS Check referrerPolicy init value of no-referrer-when-downgrade and associated getter
    17 PASS Check referrerPolicy init value of origin-only and associated getter
     17PASS Check referrerPolicy init value of origin and associated getter
    1818PASS Check referrerPolicy init value of origin-when-cross-origin and associated getter
    1919PASS Check referrerPolicy init value of unsafe-url and associated getter

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html

    r197162 r202323  
    3030                                                "no-referrer",
    3131                                                "no-referrer-when-downgrade",
    32                                                 "origin-only",
     32                                                "origin",
    3333                                                "origin-when-cross-origin",
    3434                                                "unsafe-url"
    … …  
    3737                                                  "no-referrer",
    3838                                                  "no-referrer-when-downgrade",
    39                                                   "origin-only",
     39                                                  "origin",
    4040                                                  "origin-when-cross-origin",
    4141                                                  "unsafe-url"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html

    r197162 r202323  
    1818      var initValuesDict = {"method" : "POST",
    1919                            "referrer" : "http://{{host}}:{{ports[http][0]}}/",
    20                             "referrerPolicy" : "origin-only",
     20                            "referrerPolicy" : "origin",
    2121                            "mode" : "same-origin",
    2222                            "credentials" : "include",
    … …  
    3030      var expectedInitialized = {"method" : "POST",
    3131                                 "referrer" : "http://{{host}}:{{ports[http][0]}}/",
    32                                  "referrerPolicy" : "origin-only",
     32                                 "referrerPolicy" : "origin",
    3333                                 "mode" : "same-origin",
    3434                                 "credentials" : "include",

  • trunk/Source/WebCore/ChangeLog

    r202321 r202323  
     12016-06-21  Youenn Fablet  <youennf@gmail.com>
     2
     3        [Fetch API] Rename 'origin-only' referrer policy to 'origin'
     4        https://bugs.webkit.org/show_bug.cgi?id=158982
     5
     6        Reviewed by Alex Christensen.
     7
     8        Covered by updated tests.
     9
     10        * Modules/fetch/FetchRequest.cpp:
     11        (WebCore::setReferrerPolicy): Renaming origin-only to origin.
     12        * Modules/fetch/FetchRequest.idl: Ditto.
     13        * loader/FetchOptions.h: Ditto.
     14
    1152016-06-21  Chris Dumez  <cdumez@apple.com>
    216

  • trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp

    r200361 r202323  
    4848    else if (referrerPolicy == "no-referrer-when-downgrade")
    4949        options.referrerPolicy = FetchOptions::ReferrerPolicy::NoReferrerWhenDowngrade;
    50     else if (referrerPolicy == "origin-only")
    51         options.referrerPolicy = FetchOptions::ReferrerPolicy::OriginOnly;
     50    else if (referrerPolicy == "origin")
     51        options.referrerPolicy = FetchOptions::ReferrerPolicy::Origin;
    5252    else if (referrerPolicy == "origin-when-cross-origin")
    5353        options.referrerPolicy = FetchOptions::ReferrerPolicy::OriginWhenCrossOrigin;

  • trunk/Source/WebCore/Modules/fetch/FetchRequest.idl

    r199969 r202323  
    3333enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache" };
    3434enum RequestRedirect { "follow", "error", "manual" };
    35 enum ReferrerPolicy { "", "no-referrer",  "no-referrer-when-downgrade", "origin-only", "origin-when-cross-origin", "unsafe-url" };
     35enum ReferrerPolicy { "", "no-referrer",  "no-referrer-when-downgrade", "origin", "origin-when-cross-origin", "unsafe-url" };
    3636
    3737[

  • trunk/Source/WebCore/loader/FetchOptions.h

    r201324 r202323  
    5050    Redirect redirect { Redirect::Follow };
    5151
    52     enum class ReferrerPolicy { EmptyString, NoReferrer, NoReferrerWhenDowngrade, OriginOnly, OriginWhenCrossOrigin, UnsafeUrl };
     52    enum class ReferrerPolicy { EmptyString, NoReferrer, NoReferrerWhenDowngrade, Origin, OriginWhenCrossOrigin, UnsafeUrl };
    5353    ReferrerPolicy referrerPolicy { ReferrerPolicy::EmptyString };
    5454};
Note: See TracChangeset for help on using the changeset viewer.