Changeset 202378 in webkit

Timestamp:

Jun 23, 2016 8:10:46 AM (8 years ago)

Author:

adam.bergkvist@ericsson.com

Message:

WebRTC: Align 'update ICE connection/gathering state' steps with the WebRTC 1.0 specification
​https://bugs.webkit.org/show_bug.cgi?id=159054

Reviewed by Eric Carlson.

Add checks for same state and closed RTCPeerConnection in the 'update ICE connection state'
and 'update ICE gathering state' routines as described in [1].

[1] ​https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#update-ice-gathering-state

No change in current behavior.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/RTCPeerConnection.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-23  Adam Bergkvist  <adam.bergkvist@ericsson.com>
+
+        WebRTC: Align 'update ICE connection/gathering state' steps with the WebRTC 1.0 specification
+        https://bugs.webkit.org/show_bug.cgi?id=159054
+
+        Reviewed by Eric Carlson.
+
+        Add checks for same state and closed RTCPeerConnection in the 'update ICE connection state'
+        and 'update ICE gathering state' routines as described in [1].
+
+        [1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#update-ice-gathering-state
+
+        No change in current behavior.
+
+        * Modules/mediastream/RTCPeerConnection.cpp:
+        (WebCore::RTCPeerConnection::updateIceGatheringState):
+        (WebCore::RTCPeerConnection::updateIceConnectionState):
+
 2016-06-23  Adam Bergkvist  <adam.bergkvist@ericsson.com>
 

trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

@@ -458 +458 @@
 {
     scriptExecutionContext()->postTask([=](ScriptExecutionContext&) {
+        if (m_signalingState == SignalingState::Closed || m_iceGatheringState == newState)
+            return;
+
         m_iceGatheringState = newState;
-
         dispatchEvent(Event::create(eventNames().icegatheringstatechangeEvent, false, false));
     });
@@ -467 +469 @@
 {
     scriptExecutionContext()->postTask([=](ScriptExecutionContext&) {
+        if (m_signalingState == SignalingState::Closed || m_iceConnectionState == newState)
+            return;
+
         m_iceConnectionState = newState;
-
         dispatchEvent(Event::create(eventNames().iceconnectionstatechangeEvent, false, false));
     });