Changeset 202382 in webkit

Timestamp:

Jun 23, 2016 11:43:43 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value
​https://bugs.webkit.org/show_bug.cgi?id=159053
<rdar://problem/26638119>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/variables/custom-property-computed-style-length-update.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::length):

LayoutTests:

• fast/css/variables/custom-property-computed-style-length-update-expected.txt: Added.
• fast/css/variables/custom-property-computed-style-length-update.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/variables/custom-property-computed-style-length-update-expected.txt (added)
• LayoutTests/fast/css/variables/custom-property-computed-style-length-update.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value
+        https://bugs.webkit.org/show_bug.cgi?id=159053
+        <rdar://problem/26638119>
+
+        Reviewed by Simon Fraser.
+
+        * fast/css/variables/custom-property-computed-style-length-update-expected.txt: Added.
+        * fast/css/variables/custom-property-computed-style-length-update.html: Added.
+
 2016-06-23  Adam Bergkvist  <adam.bergkvist@ericsson.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value
+        https://bugs.webkit.org/show_bug.cgi?id=159053
+        <rdar://problem/26638119>
+
+        Reviewed by Simon Fraser.
+
+        Test: fast/css/variables/custom-property-computed-style-length-update.html
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::CSSComputedStyleDeclaration::length):
+
 2016-06-23  John Wilander  <wilander@apple.com>
 

trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -3949 +3949 @@
         return 0;
 
+    updateStyleIfNeededForNode(*node);
+
     auto* style = node->computedStyle(m_pseudoElementSpecifier);
     if (!style)