Changeset 202401 in webkit

Timestamp:

Jun 23, 2016 4:22:21 PM (8 years ago)

Author:

BJ Burg

Message:

Web Inspector: add assertions to catch dangling frontends that persist between tests
​https://bugs.webkit.org/show_bug.cgi?id=159073

Reviewed by Joseph Pecoraro.

Based on the analysis in ​https://webkit.org/b/159070, we suspect that some test
flakiness might be caused by dangling frontends from previous test cases. Add an
assertion that should catch any frontends that are attached to the inspected page's
backend. There should never be any frontends connected when a test first starts.

• inspector/InspectorController.cpp:

(WebCore::InspectorController::setIsUnderTest):

• inspector/InspectorController.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorController.cpp (modified) (1 diff)
• inspector/InspectorController.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-23  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: add assertions to catch dangling frontends that persist between tests
+        https://bugs.webkit.org/show_bug.cgi?id=159073
+
+        Reviewed by Joseph Pecoraro.
+
+        Based on the analysis in https://webkit.org/b/159070, we suspect that some test
+        flakiness might be caused by dangling frontends from previous test cases. Add an
+        assertion that should catch any frontends that are attached to the inspected page's
+        backend. There should never be any frontends connected when a test first starts.
+
+        * inspector/InspectorController.cpp:
+        (WebCore::InspectorController::setIsUnderTest):
+        * inspector/InspectorController.h:
+
 2016-06-23  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebCore/inspector/InspectorController.cpp

@@ -342 +342 @@
 }
 
+void InspectorController::setIsUnderTest(bool value)
+{
+    if (value == m_isUnderTest)
+        return;
+
+    m_isUnderTest = value;
+
+    // <rdar://problem/26768628> Try to catch suspicious scenarios where we may have a dangling frontend while running tests.
+    RELEASE_ASSERT(!m_isUnderTest || !m_frontendRouter->hasFrontends());
+}
+
 void InspectorController::evaluateForTestInFrontend(const String& script)
 {

trunk/Source/WebCore/inspector/InspectorController.h

@@ -108 +108 @@
 
     bool isUnderTest() const { return m_isUnderTest; }
-    void setIsUnderTest(bool isUnderTest) { m_isUnderTest = isUnderTest; }
+    WEBCORE_EXPORT void setIsUnderTest(bool);
     WEBCORE_EXPORT void evaluateForTestInFrontend(const String& script);