Changeset 202482 in webkit


Ignore:
Timestamp:
Jun 27, 2016 2:21:51 AM (8 years ago)
Author:
Philippe Normand
Message:

[GStreamer] top/bottom black bars added needlessly in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=158980

Patch by Philippe Normand <philn@igalia.com> on 2016-06-27
Reviewed by Carlos Garcia Campos.

The natural video size calculation depends on the validity of the
current sample, so whenever the first sample reached the sink it's a
good idea to reflect this on the player which will update its natural
size accordingly.

Fixes an issue where black borders were added on top and bottom of
fullscreen video.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r202480 r202482  
     12016-06-27  Philippe Normand  <philn@igalia.com>
     2
     3        [GStreamer] top/bottom black bars added needlessly in fullscreen
     4        https://bugs.webkit.org/show_bug.cgi?id=158980
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        The natural video size calculation depends on the validity of the
     9        current sample, so whenever the first sample reached the sink it's a
     10        good idea to reflect this on the player which will update its natural
     11        size accordingly.
     12
     13        Fixes an issue where black borders were added on top and bottom of
     14        fullscreen video.
     15
     16        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
     17        (WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
     18
    1192016-06-27  Youenn Fablet  <youenn@apple.com>
    220
  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

    r202272 r202482  
    535535void MediaPlayerPrivateGStreamerBase::triggerRepaint(GstSample* sample)
    536536{
     537    bool triggerResize;
    537538    {
    538539        WTF::GMutexLocker<GMutex> lock(m_sampleMutex);
     540        triggerResize = !m_sample;
    539541        m_sample = sample;
     542    }
     543
     544    if (triggerResize) {
     545        LOG_MEDIA_MESSAGE("First sample reached the sink, triggering video dimensions update");
     546        m_player->sizeChanged();
    540547    }
    541548
Note: See TracChangeset for help on using the changeset viewer.