Changeset 202499 in webkit

Timestamp:

Jun 27, 2016 11:28:00 AM (8 years ago)

Author:

andersca@apple.com

Message:

No error message when passing an invalid API version to ApplePaySession constructor
​https://bugs.webkit.org/show_bug.cgi?id=159154

Reviewed by Tim Horton.

Log an error message if the version is not supported. Also, check for version 0 since that is also not supported.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::create):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/applepay/ApplePaySession.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-27  Anders Carlsson  <andersca@apple.com>
+
+        No error message when passing an invalid API version to ApplePaySession constructor
+        https://bugs.webkit.org/show_bug.cgi?id=159154
+
+        Reviewed by Tim Horton.
+
+        Log an error message if the version is not supported. Also, check for version 0 since that is also not supported.
+
+        * Modules/applepay/ApplePaySession.cpp:
+        (WebCore::ApplePaySession::create):
+
 2016-06-27  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp

@@ -650 +650 @@
     auto& paymentCoordinator = document.frame()->mainFrame().paymentCoordinator();
 
-    if (!paymentCoordinator.supportsVersion(version)) {
+    if (!version || !paymentCoordinator.supportsVersion(version)) {
+        window.printErrorMessage(makeString("\"" + String::number(version), "\" is not a supported version."));
         ec = INVALID_ACCESS_ERR;
         return nullptr;