Changeset 202516 in webkit

Timestamp:

Jun 27, 2016 3:13:16 PM (8 years ago)

Author:

jdiggs@igalia.com

Message:

AX: REGRESSION (r202063): ARIA role attribute is being ignored for label element
​https://bugs.webkit.org/show_bug.cgi?id=159162

Reviewed by Chris Fleizach.

Source/WebCore:

createFromRenderer() was creating an AccessibilityLabel for any HTMLLabelElement which
lacked an explicitly-handled ARIA role. We should instead create an AccessibilityLabel
when there is no ARIA role.

Test: accessibility/aria-role-on-label.html

• accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):

LayoutTests:

This regression was caught by a GTK-specific layout test. Adding a cross-platform
test for additional coverage.

• accessibility/aria-role-on-label.html: Added.
• platform/gtk/accessibility/aria-role-on-label-expected.txt: Added.
• platform/mac/accessibility/aria-role-on-label-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/aria-role-on-label.html (added)
• LayoutTests/platform/gtk/accessibility/aria-role-on-label-expected.txt (added)
• LayoutTests/platform/mac/accessibility/aria-role-on-label-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AXObjectCache.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-27  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        AX: REGRESSION (r202063): ARIA role attribute is being ignored for label element
+        https://bugs.webkit.org/show_bug.cgi?id=159162
+
+        Reviewed by Chris Fleizach.
+
+        This regression was caught by a GTK-specific layout test. Adding a cross-platform
+        test for additional coverage.
+
+        * accessibility/aria-role-on-label.html: Added.
+        * platform/gtk/accessibility/aria-role-on-label-expected.txt: Added.
+        * platform/mac/accessibility/aria-role-on-label-expected.txt: Added.
+
 2016-06-27  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-27  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        AX: REGRESSION (r202063): ARIA role attribute is being ignored for label element
+        https://bugs.webkit.org/show_bug.cgi?id=159162
+
+        Reviewed by Chris Fleizach.
+
+        createFromRenderer() was creating an AccessibilityLabel for any HTMLLabelElement which
+        lacked an explicitly-handled ARIA role. We should instead create an AccessibilityLabel
+        when there is no ARIA role.
+
+        Test: accessibility/aria-role-on-label.html
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::createFromRenderer):
+
 2016-06-27  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/accessibility/AXObjectCache.cpp

@@ -430 +430 @@
         return AccessibilityTreeItem::create(renderer);
 
-    if (node && is<HTMLLabelElement>(node))
+    if (node && is<HTMLLabelElement>(node) && nodeHasRole(node, nullAtom))
         return AccessibilityLabel::create(renderer);