Changeset 202531 in webkit
- Timestamp:
- Jun 27, 2016 6:13:53 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 12 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r202529 r202531 1 2016-06-27 Benjamin Poulain <benjamin@webkit.org> 2 3 Adopt the iOS TouchEventHandler API for cases that must have synchronous dispatch 4 https://bugs.webkit.org/show_bug.cgi?id=159179 5 rdar://problem/27006387 6 7 Reviewed by Simon Fraser. 8 9 Several of those tests expose existing bugs with overflow scrolling. 10 They are not using PASS/FAIL at the moment, just dump the called listeners. 11 12 * fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt: Added. 13 * fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html: Added. 14 * fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt: Added. 15 * fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html: Added. 16 * fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt: Added. 17 * fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html: Added. 18 * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt: Added. 19 * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html: Added. 20 * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt: Added. 21 * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html: Added. 22 * fast/events/touch/ios/drag-block-without-overflow-scroll-expected.txt: Added. 23 * fast/events/touch/ios/drag-block-without-overflow-scroll.html: Added. 24 1 25 2016-06-27 Joseph Pecoraro <pecoraro@apple.com> 2 26 -
trunk/Source/WebCore/ChangeLog
r202530 r202531 1 2016-06-27 Benjamin Poulain <benjamin@webkit.org> 2 3 Adopt the iOS TouchEventHandler API for cases that must have synchronous dispatch 4 https://bugs.webkit.org/show_bug.cgi?id=159179 5 rdar://problem/27006387 6 7 Reviewed by Simon Fraser. 8 9 Tests: fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html 10 fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html 11 fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html 12 fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html 13 fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html 14 fast/events/touch/ios/drag-block-without-overflow-scroll.html 15 16 * dom/Document.cpp: 17 (WebCore::Document::prepareForDestruction): 18 (WebCore::Document::removeAllEventListeners): 19 * dom/Node.cpp: 20 (WebCore::Node::willBeDeletedFrom): 21 (WebCore::tryAddEventListener): 22 (WebCore::tryRemoveEventListener): 23 * html/shadow/SliderThumbElement.cpp: 24 (WebCore::SliderThumbElement::registerForTouchEvents): 25 (WebCore::SliderThumbElement::unregisterForTouchEvents): 26 * rendering/RenderLayer.cpp: 27 (WebCore::RenderLayer::registerAsTouchEventListenerForScrolling): 28 (WebCore::RenderLayer::unregisterAsTouchEventListenerForScrolling): 29 1 30 2016-06-27 Alex Christensen <achristensen@webkit.org> 2 31 -
trunk/Source/WebCore/dom/Document.cpp
r202470 r202531 2333 2333 2334 2334 #if ENABLE(IOS_TOUCH_EVENTS) 2335 clearTouchEvent Listeners();2335 clearTouchEventHandlersAndListeners(); 2336 2336 #endif 2337 2337 … … 2402 2402 m_domWindow->removeAllEventListeners(); 2403 2403 #if ENABLE(IOS_TOUCH_EVENTS) 2404 clearTouchEvent Listeners();2404 clearTouchEventHandlersAndListeners(); 2405 2405 #endif 2406 2406 for (Node* node = firstChild(); node; node = NodeTraversal::next(*node)) -
trunk/Source/WebCore/dom/Node.cpp
r202172 r202531 318 318 #if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS) 319 319 document.removeTouchEventListener(this, true); 320 document.removeTouchEventHandler(this, true); 320 321 #else 321 322 // FIXME: This should call didRemoveTouchEventHandler(). … … 1934 1935 #if ENABLE(IOS_GESTURE_EVENTS) && ENABLE(TOUCH_EVENTS) 1935 1936 if (eventType == eventNames().gesturestartEvent || eventType == eventNames().gesturechangeEvent || eventType == eventNames().gestureendEvent) 1936 targetNode->document().addTouchEvent Listener(targetNode);1937 targetNode->document().addTouchEventHandler(targetNode); 1937 1938 #endif 1938 1939 … … 1975 1976 #if ENABLE(IOS_GESTURE_EVENTS) && ENABLE(TOUCH_EVENTS) 1976 1977 if (eventType == eventNames().gesturestartEvent || eventType == eventNames().gesturechangeEvent || eventType == eventNames().gestureendEvent) 1977 targetNode->document().removeTouchEvent Listener(targetNode);1978 targetNode->document().removeTouchEventHandler(targetNode); 1978 1979 #endif 1979 1980 -
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
r202105 r202531 551 551 ASSERT(shouldAcceptTouchEvents()); 552 552 553 document().addTouchEvent Listener(this);553 document().addTouchEventHandler(this); 554 554 m_isRegisteredAsTouchEventListener = true; 555 555 } … … 563 563 stopDragging(); 564 564 565 document().removeTouchEvent Listener(this);565 document().removeTouchEventHandler(this); 566 566 m_isRegisteredAsTouchEventListener = false; 567 567 } -
trunk/Source/WebCore/rendering/RenderLayer.cpp
r202292 r202531 2189 2189 return; 2190 2190 2191 renderer().document().addTouchEvent Listener(renderer().element());2191 renderer().document().addTouchEventHandler(renderer().element()); 2192 2192 m_registeredAsTouchEventListenerForScrolling = true; 2193 2193 } … … 2198 2198 return; 2199 2199 2200 renderer().document().removeTouchEvent Listener(renderer().element());2200 renderer().document().removeTouchEventHandler(renderer().element()); 2201 2201 m_registeredAsTouchEventListenerForScrolling = false; 2202 2202 }
Note: See TracChangeset
for help on using the changeset viewer.