Changeset 202570 in webkit


Ignore:
Timestamp:
Jun 28, 2016 9:45:12 AM (8 years ago)
Author:
andersca@apple.com
Message:

WebKit::WebPaymentCoordinator leak
​https://bugs.webkit.org/show_bug.cgi?id=159168
rdar://problem/26929772

Reviewed by Beth Dakin.

Source/WebCore:

  • Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::~PaymentCoordinator):
Call paymentCoordinatorDestroyed().

  • Modules/applepay/PaymentCoordinatorClient.h:

Rename mainFrameDestroyed to paymentCoordinatorDestroyed().

  • loader/EmptyClients.cpp:

Source/WebKit/mac:

Update for WebCore changes.

  • WebCoreSupport/WebPaymentCoordinatorClient.h:
  • WebCoreSupport/WebPaymentCoordinatorClient.mm:

(WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
(WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.

Source/WebKit2:

Update for WebCore changes.

  • WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::paymentCoordinatorDestroyed):
(WebKit::WebPaymentCoordinator::mainFrameDestroyed): Deleted.

  • WebProcess/ApplePay/WebPaymentCoordinator.h:
Location:
trunk/Source
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r202569 r202570  
     12016-06-27  Anders Carlsson  <andersca@apple.com>
     2
     3        WebKit::WebPaymentCoordinator leak
     4        https://bugs.webkit.org/show_bug.cgi?id=159168
     5        rdar://problem/26929772
     6
     7        Reviewed by Beth Dakin.
     8
     9        * Modules/applepay/PaymentCoordinator.cpp:
     10        (WebCore::PaymentCoordinator::~PaymentCoordinator):
     11        Call paymentCoordinatorDestroyed().
     12
     13        * Modules/applepay/PaymentCoordinatorClient.h:
     14        Rename mainFrameDestroyed to paymentCoordinatorDestroyed().
     15
     16        * loader/EmptyClients.cpp:
     17
    1182016-06-28  Frederic Wang  <fwang@igalia.com>
    219

  • trunk/Source/WebCore/Modules/applepay/PaymentCoordinator.cpp

    r202298 r202570  
    4242PaymentCoordinator::~PaymentCoordinator()
    4343{
     44    m_client.paymentCoordinatorDestroyed();
    4445}
    4546

  • trunk/Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h

    r202298 r202570  
    5151    virtual void completePaymentSession(PaymentAuthorizationStatus) = 0;
    5252    virtual void abortPaymentSession() = 0;
    53     virtual void mainFrameDestroyed() = 0;
     53    virtual void paymentCoordinatorDestroyed() = 0;
    5454
    5555protected:

  • trunk/Source/WebCore/loader/EmptyClients.cpp

    r202345 r202570  
    6464    void completePaymentSession(PaymentAuthorizationStatus) override { }
    6565    void abortPaymentSession() override { }
    66     void mainFrameDestroyed() override { }
     66    void paymentCoordinatorDestroyed() override { }
    6767};
    6868#endif

  • trunk/Source/WebKit/mac/ChangeLog

    r202524 r202570  
     12016-06-27  Anders Carlsson  <andersca@apple.com>
     2
     3        WebKit::WebPaymentCoordinator leak
     4        https://bugs.webkit.org/show_bug.cgi?id=159168
     5        rdar://problem/26929772
     6
     7        Reviewed by Beth Dakin.
     8
     9        Update for WebCore changes.
     10
     11        * WebCoreSupport/WebPaymentCoordinatorClient.h:
     12        * WebCoreSupport/WebPaymentCoordinatorClient.mm:
     13        (WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
     14        (WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
     15
    1162016-06-27  Tim Horton  <timothy_horton@apple.com>
    217

  • trunk/Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h

    r202346 r202570  
    4747    void completePaymentSession(WebCore::PaymentAuthorizationStatus) override;
    4848    void abortPaymentSession() override;
    49     void mainFrameDestroyed() override;
     49    void paymentCoordinatorDestroyed() override;
    5050};
    5151

  • trunk/Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm

    r202346 r202570  
    8484}
    8585
    86 void WebPaymentCoordinatorClient::mainFrameDestroyed()
     86void WebPaymentCoordinatorClient::paymentCoordinatorDestroyed()
    8787{
    8888    delete this;

  • trunk/Source/WebKit2/ChangeLog

    r202540 r202570  
     12016-06-27  Anders Carlsson  <andersca@apple.com>
     2
     3        WebKit::WebPaymentCoordinator leak
     4        https://bugs.webkit.org/show_bug.cgi?id=159168
     5        rdar://problem/26929772
     6
     7        Reviewed by Beth Dakin.
     8
     9        Update for WebCore changes.
     10
     11        * WebProcess/ApplePay/WebPaymentCoordinator.cpp:
     12        (WebKit::WebPaymentCoordinator::paymentCoordinatorDestroyed):
     13        (WebKit::WebPaymentCoordinator::mainFrameDestroyed): Deleted.
     14        * WebProcess/ApplePay/WebPaymentCoordinator.h:
     15
    1162016-06-27  Simon Fraser  <simon.fraser@apple.com>
    217

  • trunk/Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp

    r202432 r202570  
    124124}
    125125
    126 void WebPaymentCoordinator::mainFrameDestroyed()
     126void WebPaymentCoordinator::paymentCoordinatorDestroyed()
    127127{
    128128    delete this;

  • trunk/Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h

    r202432 r202570  
    6565    void abortPaymentSession() override;
    6666
    67     void mainFrameDestroyed() override;
     67    void paymentCoordinatorDestroyed() override;
    6868
    6969    // IPC::MessageReceiver.
Note: See TracChangeset for help on using the changeset viewer.