Changeset 202606 in webkit


Ignore:
Timestamp:
Jun 28, 2016 8:56:18 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Use a regex to check if a test step is for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=159224

Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-06-28
Reviewed by Geoffrey Garen.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:

(BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype._parseData): Replace array membership test with regex test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js

    r201626 r202606  
    110110                    if (!mostRecentFinishedIteration.productive) {
    111111                        var status = StatusLineView.Status.Danger;
    112                     } else if (mostRecentFinishedIteration.failedTestSteps.length === 1 && ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(mostRecentFinishedIteration.failedTestSteps[0].name) >= 0) {
     112                    } else if (mostRecentFinishedIteration.failedTestSteps.length === 1 && /(?=.*test)(?=.*jsc)/.test(mostRecentFinishedIteration.failedTestSteps[0].name)) {
    113113                        var failedStep = mostRecentFinishedIteration.failedTestSteps[0];
    114114                        var URL = mostRecentFinishedIteration.queue.buildbot.javaScriptCoreTestStdioUrlForIteration(mostRecentFinishedIteration, failedStep.name);
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js

    r201626 r202606  
    252252            if (step.name === "layout-test")
    253253                this.layoutTestResults = results;
    254             else if (["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(step.name) >= 0)
     254            else if (/(?=.*test)(?=.*jsc)/.test(step.name))
    255255                this.javaScriptCoreTestResults = results;
    256256            if (results.allPassed)
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js

    r201626 r202606  
    106106                        var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.tooManyFailures ? failedStep.failureCount + "\uff0b" : failedStep.failureCount, iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration));
    107107                        new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
    108                     } else if (["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(failedStep.name) >= 0) {
     108                    } else if (/(?=.*test)(?=.*jsc)/.test(failedStep.name)) {
    109109                        var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.failureCount, iteration.queue.buildbot.javaScriptCoreTestStdioUrlForIteration(iteration, failedStep.name));
    110110                        new PopoverTracker(status.statusBubbleElement, this._presentPopoverForJavaScriptCoreTestRegressions.bind(this, failedStep.name), iteration);
  • trunk/Tools/ChangeLog

    r202604 r202606  
     12016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
     2
     3        Use a regex to check if a test step is for JavaScriptCore
     4        https://bugs.webkit.org/show_bug.cgi?id=159224
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
     9        (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
     11        (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
     13        (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
     14
    1152016-06-28  Michael Saboff  <msaboff@apple.com>
    216
Note: See TracChangeset for help on using the changeset viewer.