Changeset 202660 in webkit


Ignore:
Timestamp:
Jun 29, 2016 5:12:07 PM (8 years ago)
Author:
jer.noble@apple.com
Message:

Unprefix webkit-playsinline.
https://bugs.webkit.org/show_bug.cgi?id=159283

Reviewed by Eric Carlson.

Tests: media/video-playsinline.html

media/video-webkit-playsinline.html

Unprefix the webkit-playsinline content attribute, as an unprefixed version
was added to the HTML spec by <https://github.com/whatwg/html/pull/1444>.
The new 'playsinline' content attribute reflects to a new DOM property of
the same name.

  • html/HTMLAttributeNames.in:
  • html/HTMLVideoElement.idl:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):

Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r202658 r202660  
     12016-06-29  Jer Noble  <jer.noble@apple.com>
     2
     3        Unprefix webkit-playsinline.
     4        https://bugs.webkit.org/show_bug.cgi?id=159283
     5
     6        Reviewed by Eric Carlson.
     7
     8        Tests: media/video-playsinline.html
     9               media/video-webkit-playsinline.html
     10
     11        Unprefix the webkit-playsinline content attribute, as an unprefixed version
     12        was added to the HTML spec by <https://github.com/whatwg/html/pull/1444>.
     13        The new 'playsinline' content attribute reflects to a new DOM property of
     14        the same name.
     15
     16        * html/HTMLAttributeNames.in:
     17        * html/HTMLVideoElement.idl:
     18        * html/MediaElementSession.cpp:
     19        (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
     20
    1212016-06-29  Alex Christensen  <achristensen@webkit.org>
    222
  • trunk/Source/WebCore/html/HTMLAttributeNames.in

    r199650 r202660  
    300300pattern
    301301placeholder
     302playsinline
    302303pluginspage
    303304pluginurl
  • trunk/Source/WebCore/html/HTMLVideoElement.idl

    r200361 r202660  
    3434    [Reflect, URL] attribute DOMString poster;
    3535
     36    [Reflect] attribute boolean playsinline;
    3637    readonly attribute boolean webkitSupportsFullscreen;
    3738    readonly attribute boolean webkitDisplayingFullscreen;
  • trunk/Source/WebCore/html/MediaElementSession.cpp

    r202459 r202660  
    451451        return true;
    452452
    453     return settings->inlineMediaPlaybackRequiresPlaysInlineAttribute() && !element.fastHasAttribute(HTMLNames::webkit_playsinlineAttr);
     453    return settings->inlineMediaPlaybackRequiresPlaysInlineAttribute() && !(element.fastHasAttribute(HTMLNames::webkit_playsinlineAttr) || element.fastHasAttribute(HTMLNames::playsinlineAttr));
    454454}
    455455
Note: See TracChangeset for help on using the changeset viewer.