Changeset 202683 in webkit

Timestamp:

Jun 30, 2016 10:16:39 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Date.setYear() misses timeClip()
​https://bugs.webkit.org/show_bug.cgi?id=159289

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-30
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• runtime/DatePrototype.cpp:

(JSC::dateProtoFuncSetYear):

LayoutTests:

• js/date-timeClip-large-values-expected.txt:
• js/script-tests/date-timeClip-large-values.js:

The failures are caused by bugs related to GregorianDateTime.
The last test case is the one covering this patch.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/date-timeClip-large-values-expected.txt (modified) (1 diff)
• LayoutTests/js/script-tests/date-timeClip-large-values.js (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/DatePrototype.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-30  Benjamin Poulain  <bpoulain@apple.com>
+
+        [JSC] Date.setYear() misses timeClip()
+        https://bugs.webkit.org/show_bug.cgi?id=159289
+
+        Reviewed by Geoffrey Garen.
+
+        * js/date-timeClip-large-values-expected.txt:
+        * js/script-tests/date-timeClip-large-values.js:
+        The failures are caused by bugs related to GregorianDateTime.
+        The last test case is the one covering this patch.
+
 2016-06-30  Commit Queue  <commit-queue@webkit.org>
 

trunk/LayoutTests/js/date-timeClip-large-values-expected.txt

@@ -51 +51 @@
 PASS new Date(8.64e15).setMonth(new Date(8.64e15).getMonth()).valueOf() is 8.64e15
 PASS new Date(8.64e15).setMonth(new Date(8.64e15).getMonth() + 1).valueOf() is NaN
+Testing setYear()
+PASS new Date(0).setYear(Infinity).valueOf() is NaN
+FAIL new Date(0).setYear(1.79769e+308).valueOf() should be NaN. Was -62135596800000.
+FAIL new Date(0).setYear(-1.79769e+308).valueOf() should be NaN. Was -62135596800000.
+PASS new Date(8.64e15).setYear(new Date(8.64e15).getFullYear()).valueOf() is 8.64e15
+PASS new Date(8.64e15).setYear(new Date(8.64e15).getFullYear() + 1).valueOf() is NaN
 Testing setFullYear()
 PASS new Date(0).setFullYear(Infinity).valueOf() is NaN

trunk/LayoutTests/js/script-tests/date-timeClip-large-values.js

@@ -54 +54 @@
 shouldBe("new Date(8.64e15).setMonth(new Date(8.64e15).getMonth()).valueOf()", "8.64e15");
 shouldBe("new Date(8.64e15).setMonth(new Date(8.64e15).getMonth() + 1).valueOf()", "NaN");
+
+debug("Testing setYear()");
+shouldBe("new Date(0).setYear(Infinity).valueOf()", "NaN");
+shouldBe("new Date(0).setYear(1.79769e+308).valueOf()", "NaN");
+shouldBe("new Date(0).setYear(-1.79769e+308).valueOf()", "NaN");
+shouldBe("new Date(8.64e15).setYear(new Date(8.64e15).getFullYear()).valueOf()", "8.64e15");
+shouldBe("new Date(8.64e15).setYear(new Date(8.64e15).getFullYear() + 1).valueOf()", "NaN");
 
 debug("Testing setFullYear()");

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-06-30  Benjamin Poulain  <bpoulain@apple.com>
+
+        [JSC] Date.setYear() misses timeClip()
+        https://bugs.webkit.org/show_bug.cgi?id=159289
+
+        Reviewed by Geoffrey Garen.
+
+        * runtime/DatePrototype.cpp:
+        (JSC::dateProtoFuncSetYear):
+
 2016-06-30  Joseph Pecoraro  <pecoraro@apple.com> and Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp

@@ -1075 +1075 @@
 
     gregorianDateTime.setYear(toInt32((year >= 0 && year <= 99) ? (year + 1900) : year));
-    JSValue result = jsNumber(gregorianDateTimeToMS(vm, gregorianDateTime, ms, WTF::LocalTime));
+    double timeInMilliseconds = gregorianDateTimeToMS(vm, gregorianDateTime, ms, WTF::LocalTime);
+    JSValue result = jsNumber(timeClip(timeInMilliseconds));
     thisDateObj->setInternalValue(vm, result);
     return JSValue::encode(result);