Changeset 202742 in webkit

Timestamp:

Jul 1, 2016 10:06:57 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Make enabling protocol logging in inspector tests easy to remember
​https://bugs.webkit.org/show_bug.cgi?id=159323

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-01
Reviewed by Brian Burg.

Now you just need to type InspectorTest.debug() or
ProtocolTest.debug() and it will include stderr logging.

• UserInterface/Test/FrontendTestHarness.js:

(FrontendTestHarness.prototype.debug):

• UserInterface/Test/ProtocolTestHarness.js:

(ProtocolTestHarness.prototype.debug):
(ProtocolTestHarness):

• UserInterface/Test/TestHarness.js:

(TestHarness.prototype.debug):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Test/FrontendTestHarness.js (modified) (1 diff)
• UserInterface/Test/ProtocolTestHarness.js (modified) (1 diff)
• UserInterface/Test/TestHarness.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-07-01  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Make enabling protocol logging in inspector tests easy to remember
+        https://bugs.webkit.org/show_bug.cgi?id=159323
+
+        Reviewed by Brian Burg.
+
+        Now you just need to type InspectorTest.debug() or
+        ProtocolTest.debug() and it will include stderr logging.
+
+        * UserInterface/Test/FrontendTestHarness.js:
+        (FrontendTestHarness.prototype.debug):
+        * UserInterface/Test/ProtocolTestHarness.js:
+        (ProtocolTestHarness.prototype.debug):
+        (ProtocolTestHarness):
+        * UserInterface/Test/TestHarness.js:
+        (TestHarness.prototype.debug):
+
 2016-06-30  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js

@@ -87 +87 @@
     }
 
+    debug()
+    {
+        this.dumpActivityToSystemConsole = true;
+        InspectorBackend.dumpInspectorProtocolMessages = true;
+    }
+
     // Frontend test-specific methods.
 

trunk/Source/WebInspectorUI/UserInterface/Test/ProtocolTestHarness.js

@@ -70 +70 @@
             return InspectorProtocol.awaitCommand(args);
     }
+
+    debug()
+    {
+        this.dumpActivityToSystemConsole = true;
+        this.dumpInspectorProtocolMessages = true;
+    }
 }

trunk/Source/WebInspectorUI/UserInterface/Test/TestHarness.js

@@ -49 +49 @@
 
     evaluateInPage(string, callback)
+    {
+        throw new Error("Must be implemented by subclasses.");
+    }
+
+    debug()
     {
         throw new Error("Must be implemented by subclasses.");