Changeset 202766 in webkit


Ignore:
Timestamp:
Jul 1, 2016 5:55:44 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Sending XHR with UTF8 encoded data shows garbled data in Resource sidebar
https://bugs.webkit.org/show_bug.cgi?id=159358

Patch by Johan K. Jensen <jj@johanjensen.dk> on 2016-07-01
Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: http/tests/inspector/network/xhr-request-data-encoded-correctly.html

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::buildObjectForResourceRequest):

LayoutTests:

Based on Chromium patch:
<https://chromium.googlesource.com/chromium/src/+/bcbb663864624ab38b36731eb2edc839a90f9e65%5E%21/#F2>

  • http/tests/inspector/network/xhr-request-data-encoded-correctly-expected.txt:
  • http/tests/inspector/network/xhr-request-data-encoded-correctly.html:
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r202765 r202766  
     12016-07-01  Johan K. Jensen  <jj@johanjensen.dk>
     2
     3        Web Inspector: Sending XHR with UTF8 encoded data shows garbled data in Resource sidebar
     4        https://bugs.webkit.org/show_bug.cgi?id=159358
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Based on Chromium patch:
     9        <https://chromium.googlesource.com/chromium/src/+/bcbb663864624ab38b36731eb2edc839a90f9e65%5E%21/#F2>
     10
     11        * http/tests/inspector/network/xhr-request-data-encoded-correctly-expected.txt:
     12        * http/tests/inspector/network/xhr-request-data-encoded-correctly.html:
     13
    1142016-07-01  Dean Jackson  <dino@apple.com>
    215
  • trunk/Source/WebCore/ChangeLog

    r202765 r202766  
     12016-07-01  Johan K. Jensen  <jj@johanjensen.dk>
     2
     3        Web Inspector: Sending XHR with UTF8 encoded data shows garbled data in Resource sidebar
     4        https://bugs.webkit.org/show_bug.cgi?id=159358
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Test: http/tests/inspector/network/xhr-request-data-encoded-correctly.html
     9
     10        * inspector/InspectorNetworkAgent.cpp:
     11        (WebCore::buildObjectForResourceRequest):
     12
    1132016-07-01  Dean Jackson  <dino@apple.com>
    214
  • trunk/Source/WebCore/inspector/InspectorNetworkAgent.cpp

    r202542 r202766  
    206206        .setHeaders(buildObjectForHeaders(request.httpHeaderFields()))
    207207        .release();
    208     if (request.httpBody() && !request.httpBody()->isEmpty())
    209         requestObject->setPostData(request.httpBody()->flattenToString());
     208    if (request.httpBody() && !request.httpBody()->isEmpty()) {
     209        Vector<char> bytes;
     210        request.httpBody()->flatten(bytes);
     211        requestObject->setPostData(String::fromUTF8WithLatin1Fallback(bytes.data(), bytes.size()));
     212    }
    210213    return requestObject;
    211214}
Note: See TracChangeset for help on using the changeset viewer.