Changeset 202773 in webkit

Timestamp:

Jul 1, 2016 8:03:25 PM (8 years ago)

Author:

Hunseop Jeong

Message:

[EFL] Many layout tests are timeout after r202532.
​https://bugs.webkit.org/show_bug.cgi?id=159337

Reviewed by Gyuyoung Kim.

WebPageProxy::forceRepaint() wait for the next commit from the web process
after r202532, but WebPageProxy::callAfterNextPresentationUpdate() is not
implemented in CoordinatedDrawingAreaProxy.

• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::contentsRect):
(WebKit::CoordinatedDrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::CoordinatedDrawingAreaProxy::sizeDidChange):

• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:

(WebKit::CoordinatedDrawingAreaProxy::page):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp (modified) (1 diff)
• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-07-01  Hunseop Jeong  <hs85.jeong@samsung.com>
+
+        [EFL] Many layout tests are timeout after r202532.
+        https://bugs.webkit.org/show_bug.cgi?id=159337
+
+        Reviewed by Gyuyoung Kim.
+
+        WebPageProxy::forceRepaint() wait for the next commit from the web process
+        after r202532, but WebPageProxy::callAfterNextPresentationUpdate() is not 
+        implemented in CoordinatedDrawingAreaProxy.
+
+        * UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
+        (WebKit::CoordinatedDrawingAreaProxy::contentsRect):
+        (WebKit::CoordinatedDrawingAreaProxy::dispatchAfterEnsuringDrawing):
+        (WebKit::CoordinatedDrawingAreaProxy::sizeDidChange):
+        * UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
+        (WebKit::CoordinatedDrawingAreaProxy::page):
+
 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp

@@ -73 +73 @@
 }
 
+void CoordinatedDrawingAreaProxy::dispatchAfterEnsuringDrawing(std::function<void(CallbackBase::Error)> callbackFunction)
+{
+    if (!m_webPageProxy.isValid()) {
+        callbackFunction(CallbackBase::Error::OwnerWasInvalidated);
+        return;
+    }
+
+    RunLoop::main().dispatch([callbackFunction] {
+        callbackFunction(CallbackBase::Error::None);
+    });
+}
+
 void CoordinatedDrawingAreaProxy::sizeDidChange()
 {

trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h

@@ -62 +62 @@
 
     WebPageProxy& page() { return m_webPageProxy; }
+    
+    void dispatchAfterEnsuringDrawing(std::function<void(CallbackBase::Error)>) override;
+
 private:
     // DrawingAreaProxy