Changeset 202819 in webkit


Ignore:
Timestamp:
Jul 5, 2016 9:52:26 AM (8 years ago)
Author:
ap@apple.com
Message:

run-webkit-tests should print more complete baseline search paths
https://bugs.webkit.org/show_bug.cgi?id=159354

Reviewed by Daniel Bates.

run-webkit-tests used to only print directory names in baseline search paths.
This was ok in basic usage, but quickly got confusing when using
--additional-platform-directory flags.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_config):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r202809 r202819  
     12016-07-05  Alexey Proskuryakov  <ap@apple.com>
     2
     3        run-webkit-tests should print more complete baseline search paths
     4        https://bugs.webkit.org/show_bug.cgi?id=159354
     5
     6        Reviewed by Daniel Bates.
     7
     8        run-webkit-tests used to only print directory names in baseline search paths.
     9        This was ok in basic usage, but quickly got confusing when using
     10        --additional-platform-directory flags.
     11
     12        * Scripts/webkitpy/layout_tests/views/printing.py:
     13        (Printer.print_config):
     14        * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
     15        (Testprinter.test_print_config):
     16        (Testprinter.test_print_one_line_summary):
     17
    1182016-07-04  Brady Eidson  <beidson@apple.com>
    219
  • trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py

    r202362 r202819  
    8383
    8484        fs = self._port.host.filesystem
    85         fallback_path = [fs.split(x)[1] for x in self._port.baseline_search_path()]
     85        fallback_path = [fs.relpath(x, self._port.layout_tests_dir()).replace("../", "") for x in self._port.baseline_search_path()]
    8686        self._print_default("Baseline search path: %s -> generic" % " -> ".join(fallback_path))
    8787
  • trunk/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py

    r192565 r202819  
    112112        self.assertIn('Test configuration: <leopard, x86, release>', err.getvalue())
    113113        self.assertIn('Placing test results in /tmp', err.getvalue())
    114         self.assertIn('Baseline search path: test-mac-leopard -> test-mac-snowleopard -> generic', err.getvalue())
     114        self.assertIn('Baseline search path: platform/test-mac-leopard -> platform/test-mac-snowleopard -> generic', err.getvalue())
    115115        self.assertIn('Using Release build', err.getvalue())
    116116        self.assertIn('Pixel tests enabled', err.getvalue())
     
    121121        printer._options.quiet = True
    122122        printer.print_config('/tmp')
    123         self.assertNotIn('Baseline search path: test-mac-leopard -> test-mac-snowleopard -> generic', err.getvalue())
     123        self.assertNotIn('Baseline search path: platform/test-mac-leopard -> platform/test-mac-snowleopard -> generic', err.getvalue())
    124124
    125125    def test_print_one_line_summary(self):
Note: See TracChangeset for help on using the changeset viewer.