Changeset 202872 in webkit


Ignore:
Timestamp:
Jul 6, 2016 1:03:09 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Do not animate video fullscreen exit when page has navigated away.
https://bugs.webkit.org/show_bug.cgi?id=159479

Patch by Jeremy Jones <jeremyj@apple.com> on 2016-07-06
Reviewed by Eric Carlson.

No new tests there is no effect on the DOM. The only effect is to video fullscreen window animation.

When the page has been navigated away, the fullscreen or picture-in-picture window should
not animate back inline in the page, since the page has already navigated to a new page.
Instead exit the fullscreen mode without animating.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::exitFullscreen):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r202871 r202872  
     12016-07-06  Jeremy Jones  <jeremyj@apple.com>
     2
     3        Do not animate video fullscreen exit when page has navigated away.
     4        https://bugs.webkit.org/show_bug.cgi?id=159479
     5
     6        Reviewed by Eric Carlson.
     7
     8        No new tests there is no effect on the DOM. The only effect is to video fullscreen window animation.
     9
     10        When the page has been navigated away, the fullscreen or picture-in-picture window should
     11        not animate back inline in the page, since the page has already navigated to a new page.
     12        Instead exit the fullscreen mode without animating.
     13
     14        * html/HTMLMediaElement.cpp:
     15        (WebCore::HTMLMediaElement::exitFullscreen):
     16
    1172016-07-06  Jeremy Jones  <jeremyj@apple.com>
    218
  • trunk/Source/WebCore/html/HTMLMediaElement.cpp

    r202871 r202872  
    54425442            pauseInternal();
    54435443
     5444#if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)
     5445        if (document().activeDOMObjectsAreSuspended() || document().activeDOMObjectsAreStopped())
     5446            document().page()->chrome().client().exitVideoFullscreenToModeWithoutAnimation(downcast<HTMLVideoElement>(*this), VideoFullscreenModeNone);
     5447        else
     5448#endif
    54445449        if (document().page()->chrome().client().supportsVideoFullscreen(oldVideoFullscreenMode)) {
    54455450            document().page()->chrome().client().exitVideoFullscreenForVideoElement(downcast<HTMLVideoElement>(*this));
Note: See TracChangeset for help on using the changeset viewer.