Changeset 202891 in webkit

Timestamp:

Jul 6, 2016 8:25:51 PM (8 years ago)

Author:

timothy@apple.com

Message:

Web Inspector: REGRESSION: Hitting ⌘T in Web Inspector no longer opens in new tab in Safari
​https://bugs.webkit.org/show_bug.cgi?id=159487
rdar://problem/27188047

Change Command-T to Command-Option-T to open a new tab.

I also changed Command-1, etc. to Command-Option-1, etc. to switch tabs. The number commands
conflicted similarly with Safari and didn't work for me as a Web Inspector shortcut at all.
We can't use Command-Shift because of Command-Shift-3 and Command-Shift-4 for screenshots.

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-07-06  Timothy Hatcher  <timothy@apple.com>
+
+        Web Inspector: REGRESSION: Hitting ⌘T in Web Inspector no longer opens in new tab in Safari
+        https://bugs.webkit.org/show_bug.cgi?id=159487
+        rdar://problem/27188047
+
+        Change Command-T to Command-Option-T to open a new tab.
+
+        I also changed Command-1, etc. to Command-Option-1, etc. to switch tabs. The number commands
+        conflicted similarly with Safari and didn't work for me as a Web Inspector shortcut at all.
+        We can't use Command-Shift because of Command-Shift-3 and Command-Shift-4 for screenshots.
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Base/Main.js:
+        (WebInspector.contentLoaded):
+
 2016-07-06  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -269 +269 @@
     this._resetZoomKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, "0", this._resetZoom.bind(this));
 
-    this._showTabAtIndexKeyboardShortcuts = [1, 2, 3, 4, 5, 6, 7, 8, 9].map((i) => new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, `${i}`, this._showTabAtIndex.bind(this, i)));
-    this._openNewTabKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, "T", this.showNewTabTab.bind(this));
+    this._showTabAtIndexKeyboardShortcuts = [1, 2, 3, 4, 5, 6, 7, 8, 9].map((i) => new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Option, `${i}`, this._showTabAtIndex.bind(this, i)));
+    this._openNewTabKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Option, "T", this.showNewTabTab.bind(this));
 
     this.tabBrowser = new WebInspector.TabBrowser(document.getElementById("tab-browser"), this.tabBar, this.navigationSidebar, this.detailsSidebar);