Changeset 202909 in webkit

Timestamp:

Jul 7, 2016 9:03:18 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[Fetch API] Response.redirect should throw a RangeError in case of bad status code
​https://bugs.webkit.org/show_bug.cgi?id=159507

Patch by Youenn Fablet <​youenn@apple.com> on 2016-07-07
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/response/response-static-redirect-expected.txt:

Source/WebCore:

Covered by rebased test.

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::redirect): Throw a RangeError in case of bad status.

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-static-redirect-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/fetch/FetchResponse.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-07-07  Youenn Fablet  <youenn@apple.com>
+
+        [Fetch API] Response.redirect should throw a RangeError in case of bad status code
+        https://bugs.webkit.org/show_bug.cgi?id=159507
+
+        Reviewed by Alex Christensen.
+
+        * web-platform-tests/fetch/api/response/response-static-redirect-expected.txt:
+
 2016-07-06  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-static-redirect-expected.txt

@@ -7 +7 @@
 PASS Check response returned by static method redirect(), status = 308 
 PASS Check error returned when giving invalid url to redirect() 
-FAIL Check error returned when giving invalid status to redirect(), status = 200 assert_throws: Expect RangeError exception function "function () { Response.redirect(url, invalidStatus); }" threw object "TypeError: Type error" ("TypeError") expected object "RangeError" ("RangeError")
-FAIL Check error returned when giving invalid status to redirect(), status = 309 assert_throws: Expect RangeError exception function "function () { Response.redirect(url, invalidStatus); }" threw object "TypeError: Type error" ("TypeError") expected object "RangeError" ("RangeError")
-FAIL Check error returned when giving invalid status to redirect(), status = 400 assert_throws: Expect RangeError exception function "function () { Response.redirect(url, invalidStatus); }" threw object "TypeError: Type error" ("TypeError") expected object "RangeError" ("RangeError")
-FAIL Check error returned when giving invalid status to redirect(), status = 500 assert_throws: Expect RangeError exception function "function () { Response.redirect(url, invalidStatus); }" threw object "TypeError: Type error" ("TypeError") expected object "RangeError" ("RangeError")
+PASS Check error returned when giving invalid status to redirect(), status = 200 
+PASS Check error returned when giving invalid status to redirect(), status = 309 
+PASS Check error returned when giving invalid status to redirect(), status = 400 
+PASS Check error returned when giving invalid status to redirect(), status = 500 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-07  Youenn Fablet  <youenn@apple.com>
+
+        [Fetch API] Response.redirect should throw a RangeError in case of bad status code
+        https://bugs.webkit.org/show_bug.cgi?id=159507
+
+        Reviewed by Alex Christensen.
+
+        Covered by rebased test.
+
+        * Modules/fetch/FetchResponse.cpp:
+        (WebCore::FetchResponse::redirect): Throw a RangeError in case of bad status.
+
 2016-07-05  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp

@@ -66 +66 @@
     }
     if (!isRedirectStatus(status)) {
-        ec = TypeError;
+        ec = RangeError;
         return nullptr;
     }