Changeset 203002 in webkit


Ignore:
Timestamp:
Jul 8, 2016 12:40:20 PM (8 years ago)
Author:
mmaxfield@apple.com
Message:

[Font Loading] The callback passed to document.fonts.ready should always be called
https://bugs.webkit.org/show_bug.cgi?id=158884

Reviewed by Dean Jackson.

Source/WebCore:

The boolean was simply not being reset when loads start.

Test: fast/text/font-face-set-ready-fire.html

  • css/FontFaceSet.cpp:

(WebCore::FontFaceSet::startedLoading):

  • css/FontFaceSet.h:

LayoutTests:

  • TestExpectations:
  • fast/text/font-face-set-ready-fire-expected.txt: Added.
  • fast/text/font-face-set-ready-fire.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r202999 r203002  
     12016-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        [Font Loading] The callback passed to document.fonts.ready should always be called
     4        https://bugs.webkit.org/show_bug.cgi?id=158884
     5
     6        Reviewed by Dean Jackson.
     7
     8        * TestExpectations:
     9        * fast/text/font-face-set-ready-fire-expected.txt: Added.
     10        * fast/text/font-face-set-ready-fire.html: Added.
     11
    1122016-07-08  Ryan Haddad  <ryanhaddad@apple.com>
    213
  • trunk/LayoutTests/TestExpectations

    r202988 r203002  
    985985
    986986[ Debug ] js/regress/misc-bugs-847389-jpeg2000.html [ Skip ]
    987 
    988 # These tests time out due to https://bugs.webkit.org/show_bug.cgi?id=158884
    989 imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html [ Timeout ]
    990 imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1.html [ Timeout ]
    991 imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html [ Timeout ]
    992 imported/mathml-in-html5/mathml/presentation-markup/tables/table-axis-height.html [ Timeout ]
    993 imported/mathml-in-html5/mathml/relations/css-styling/displaystyle-1.html [ Timeout ]
  • trunk/Source/WebCore/ChangeLog

    r202995 r203002  
     12016-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        [Font Loading] The callback passed to document.fonts.ready should always be called
     4        https://bugs.webkit.org/show_bug.cgi?id=158884
     5
     6        Reviewed by Dean Jackson.
     7
     8        The boolean was simply not being reset when loads start.
     9
     10        Test: fast/text/font-face-set-ready-fire.html
     11
     12        * css/FontFaceSet.cpp:
     13        (WebCore::FontFaceSet::startedLoading):
     14        * css/FontFaceSet.h:
     15
    1162016-07-08  Commit Queue  <commit-queue@webkit.org>
    217
  • trunk/Source/WebCore/css/FontFaceSet.cpp

    r202983 r203002  
    198198{
    199199    // FIXME: Fire a "loading" event asynchronously.
     200    m_isReady = false;
    200201}
    201202
  • trunk/Source/WebCore/css/FontFaceSet.h

    r202983 r203002  
    112112    HashMap<RefPtr<CSSFontFace>, Vector<Ref<PendingPromise>>> m_pendingPromises;
    113113    Optional<ReadyPromise> m_promise;
    114     bool m_isReady { false };
     114    bool m_isReady { true };
    115115};
    116116
Note: See TracChangeset for help on using the changeset viewer.