Changeset 203820 in webkit

Timestamp:

Jul 28, 2016 11:04:22 AM (8 years ago)

Author:

Chris Dumez

Message:

Parameters to CanvasGradient.addColorStop() should be mandatory
​https://bugs.webkit.org/show_bug.cgi?id=160297

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

• web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Parameters to CanvasGradient.addColorStop() should be mandatory:

• ​https://html.spec.whatwg.org/multipage/scripting.html#canvasgradient

Firefox and Chrome agree with the specification.

No new tests, rebaselined existing test.

• html/canvas/CanvasGradient.idl:

LayoutTests:

Rebaseline existing test due to behavior change.

• platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (modified) (1 diff)
• LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/canvas/CanvasGradient.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-28  Chris Dumez  <cdumez@apple.com>
+
+        Parameters to CanvasGradient.addColorStop() should be mandatory
+        https://bugs.webkit.org/show_bug.cgi?id=160297
+
+        Reviewed by Alex Christensen.
+
+        Rebaseline existing test due to behavior change.
+
+        * platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
+
 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-07-28  Chris Dumez  <cdumez@apple.com>
+
+        Parameters to CanvasGradient.addColorStop() should be mandatory
+        https://bugs.webkit.org/show_bug.cgi?id=160297
+
+        Reviewed by Alex Christensen.
+
+        Rebaseline W3C test now that one more check is passing.
+
+        * web-platform-tests/html/dom/interfaces-expected.txt:
+
 2016-07-28  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt

@@ -5091 +5091 @@
 PASS CanvasGradient interface: existence and properties of interface prototype object 
 PASS CanvasGradient interface: existence and properties of interface prototype object's "constructor" property 
-FAIL CanvasGradient interface: operation addColorStop(double,DOMString) assert_equals: property has wrong .length expected 2 but got 0
+PASS CanvasGradient interface: operation addColorStop(double,DOMString) 
 PASS CanvasPattern interface: existence and properties of interface object 
 PASS CanvasPattern interface object length 

trunk/LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt

@@ -1 @@
-Failed assertion: expected exception of type SyntaxError, got: SyntaxError (DOM Exception 12): The string did not match the expected pattern.
+Failed assertion: expected exception of type SyntaxError, got: TypeError: Not enough arguments

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-28  Chris Dumez  <cdumez@apple.com>
+
+        Parameters to CanvasGradient.addColorStop() should be mandatory
+        https://bugs.webkit.org/show_bug.cgi?id=160297
+
+        Reviewed by Alex Christensen.
+
+        Parameters to CanvasGradient.addColorStop() should be mandatory:
+        - https://html.spec.whatwg.org/multipage/scripting.html#canvasgradient
+
+        Firefox and Chrome agree with the specification.
+
+        No new tests, rebaselined existing test.
+
+        * html/canvas/CanvasGradient.idl:
+
 2016-07-28  Romain Bellessort  <romain.bellessort@crf.canon.fr>
 

trunk/Source/WebCore/html/canvas/CanvasGradient.idl

@@ -26 +26 @@
     ImplementationLacksVTable,
 ] interface CanvasGradient {
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    [RaisesException] void addColorStop(optional float offset = NaN, optional DOMString color = "undefined");
+    [RaisesException] void addColorStop(float offset, DOMString color);
 };