Changeset 203821 in webkit


Ignore:
Timestamp:
Jul 28, 2016 11:14:18 AM (8 years ago)
Author:
Chris Dumez
Message:

First parameter to SVGDocument.createEvent() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160296

Reviewed by Alex Christensen.

Source/WebCore:

First parameter to SVGDocument.createEvent() should be mandatory:

This patch drops createEvent() from SVGDocument so that the spec-compliant
Document.createEvent() is used instead. In the specification, SVGDocument
no longer exists and is a simple Document.

Firefox and Chrome agree with the specification.

Test: svg/dom/SVGDocument-createEvent.html

  • svg/SVGDocument.idl:

LayoutTests:

Add test coverage.

  • svg/dom/SVGDocument-createEvent-expected.txt: Added.
  • svg/dom/SVGDocument-createEvent.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r203820 r203821  
     12016-07-28  Chris Dumez  <cdumez@apple.com>
     2
     3        First parameter to SVGDocument.createEvent() should be mandatory
     4        https://bugs.webkit.org/show_bug.cgi?id=160296
     5
     6        Reviewed by Alex Christensen.
     7
     8        Add test coverage.
     9
     10        * svg/dom/SVGDocument-createEvent-expected.txt: Added.
     11        * svg/dom/SVGDocument-createEvent.html: Added.
     12
    1132016-07-28  Chris Dumez  <cdumez@apple.com>
    214
  • trunk/Source/WebCore/ChangeLog

    r203820 r203821  
     12016-07-28  Chris Dumez  <cdumez@apple.com>
     2
     3        First parameter to SVGDocument.createEvent() should be mandatory
     4        https://bugs.webkit.org/show_bug.cgi?id=160296
     5
     6        Reviewed by Alex Christensen.
     7
     8        First parameter to SVGDocument.createEvent() should be mandatory:
     9        - https://www.w3.org/TR/SVG2/struct.html#InterfaceDocumentExtensions
     10        - https://dom.spec.whatwg.org/#document
     11
     12        This patch drops createEvent() from SVGDocument so that the spec-compliant
     13        Document.createEvent() is used instead. In the specification, SVGDocument
     14        no longer exists and is a simple Document.
     15
     16        Firefox and Chrome agree with the specification.
     17
     18        Test: svg/dom/SVGDocument-createEvent.html
     19
     20        * svg/SVGDocument.idl:
     21
    1222016-07-28  Chris Dumez  <cdumez@apple.com>
    223
  • trunk/Source/WebCore/svg/SVGDocument.idl

    r199969 r203821  
    2222// FIXME: This interface no longer exists in SVG2.
    2323interface SVGDocument : XMLDocument {
    24     readonly attribute SVGSVGElement        rootElement;
    25 
    26     // Overwrite the one in events::DocumentEvent
    27     // FIXME: Using "undefined" as default parameter value is wrong.
    28     [RaisesException] Event createEvent(optional DOMString eventType = "undefined");
     24    readonly attribute SVGSVGElement? rootElement;
    2925};
    3026
Note: See TracChangeset for help on using the changeset viewer.