Changeset 203833 in webkit


Ignore:
Timestamp:
Jul 28, 2016 1:21:33 PM (8 years ago)
Author:
Chris Dumez
Message:

Parameter to tr.deleteCell() should be mandatory
​https://bugs.webkit.org/show_bug.cgi?id=160308

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Parameter to tr.deleteCell() should be mandatory:

Firefox and Chrome agree with the specification.

No new tests, rebaselined existing tests.

  • html/HTMLTableRowElement.idl:

Source/WebInspectorUI:

Report tr.deleteCell() parameter as mandatory.

  • UserInterface/Models/NativeFunctionParameters.js:

LayoutTests:

Update existing test to reflect behavior change.

  • fast/dom/non-numeric-values-numeric-parameters-expected.txt:
  • fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r203828 r203833  
     12016-07-28  Chris Dumez  <cdumez@apple.com>
     2
     3        Parameter to tr.deleteCell() should be mandatory
     4        https://bugs.webkit.org/show_bug.cgi?id=160308
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Update existing test to reflect behavior change.
     9
     10        * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
     11        * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
     12
    1132016-07-28  Ryan Haddad  <ryanhaddad@apple.com>
    214

  • trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt

    r203795 r203833  
    3737PASS nonNumericPolicy('createHTMLTableElement().deleteRow(x)') is 'any type allowed'
    3838PASS nonNumericPolicy('createHTMLTableRowElement().insertCell(x)') is 'any type allowed'
    39 PASS nonNumericPolicy('createHTMLTableRowElement().deleteCell(x)') is 'any type allowed'
     39PASS nonNumericPolicy('createHTMLTableRowElement().deleteCell(x)') is 'any type allowed (but not omitted)'
    4040PASS nonNumericPolicy('createHTMLTableSectionElement().insertRow(x)') is 'any type allowed'
    4141PASS nonNumericPolicy('createHTMLTableSectionElement().deleteRow(x)') is 'any type allowed'

  • trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

    r203795 r203833  
    261261
    262262shouldBe("nonNumericPolicy('createHTMLTableRowElement().insertCell(x)')", "'any type allowed'");
    263 shouldBe("nonNumericPolicy('createHTMLTableRowElement().deleteCell(x)')", "'any type allowed'");
     263shouldBe("nonNumericPolicy('createHTMLTableRowElement().deleteCell(x)')", "'any type allowed (but not omitted)'");
    264264
    265265// HTMLTableSectionElement

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r203831 r203833  
     12016-07-28  Chris Dumez  <cdumez@apple.com>
     2
     3        Parameter to tr.deleteCell() should be mandatory
     4        https://bugs.webkit.org/show_bug.cgi?id=160308
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Rebaseline W3C test now that more checks are passing.
     9
     10        * web-platform-tests/html/dom/interfaces-expected.txt:
     11
    1122016-07-28  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt

    r203831 r203833  
    25892589PASS HTMLTableRowElement interface: attribute cells
    25902590PASS HTMLTableRowElement interface: operation insertCell(long)
    2591 FAIL HTMLTableRowElement interface: operation deleteCell(long) assert_equals: property has wrong .length expected 1 but got 0
     2591PASS HTMLTableRowElement interface: operation deleteCell(long)
    25922592PASS HTMLTableRowElement interface: attribute align
    25932593PASS HTMLTableRowElement interface: attribute ch
    … …  
    26032603PASS HTMLTableRowElement interface: calling insertCell(long) on document.createElement("tr") with too few arguments must throw TypeError
    26042604PASS HTMLTableRowElement interface: document.createElement("tr") must inherit property "deleteCell" with the proper type (4)
    2605 FAIL HTMLTableRowElement interface: calling deleteCell(long) on document.createElement("tr") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
    2606             fn.apply(obj, args);
    2607         }" threw object "IndexSizeError (DOM Exception 1): The index is not in the..." ("IndexSizeError") expected object "TypeError" ("TypeError")
     2605PASS HTMLTableRowElement interface: calling deleteCell(long) on document.createElement("tr") with too few arguments must throw TypeError
    26082606PASS HTMLTableRowElement interface: document.createElement("tr") must inherit property "align" with the proper type (5)
    26092607PASS HTMLTableRowElement interface: document.createElement("tr") must inherit property "ch" with the proper type (6)

  • trunk/Source/WebCore/ChangeLog

    r203831 r203833  
     12016-07-28  Chris Dumez  <cdumez@apple.com>
     2
     3        Parameter to tr.deleteCell() should be mandatory
     4        https://bugs.webkit.org/show_bug.cgi?id=160308
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Parameter to tr.deleteCell() should be mandatory:
     9        - https://html.spec.whatwg.org/multipage/tables.html#htmltablerowelement
     10
     11        Firefox and Chrome agree with the specification.
     12
     13        No new tests, rebaselined existing tests.
     14
     15        * html/HTMLTableRowElement.idl:
     16
    1172016-07-28  Chris Dumez  <cdumez@apple.com>
    218

  • trunk/Source/WebCore/html/HTMLTableRowElement.idl

    r203527 r203833  
    2929    [Reflect] attribute DOMString vAlign;
    3030    [RaisesException] HTMLElement insertCell(optional long index = -1);
    31     [RaisesException] void deleteCell(optional long index = 0);
     31    [RaisesException] void deleteCell(long index);
    3232};
    3333

  • trunk/Source/WebInspectorUI/ChangeLog

    r203807 r203833  
     12016-07-28  Chris Dumez  <cdumez@apple.com>
     2
     3        Parameter to tr.deleteCell() should be mandatory
     4        https://bugs.webkit.org/show_bug.cgi?id=160308
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Report tr.deleteCell() parameter as mandatory.
     9
     10        * UserInterface/Models/NativeFunctionParameters.js:
     11
    1122016-07-27  Nikita Vasilyev  <nvasilyev@apple.com>
    213

  • trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js

    r201650 r203833  
    969969
    970970    HTMLTableRowElement: {
    971         deleteCell: "[index]",
     971        deleteCell: "index",
    972972        insertCell: "[index]",
    973973        __proto__: null,
Note: See TracChangeset for help on using the changeset viewer.