Changeset 203840 in webkit
- Timestamp:
- Jul 28, 2016 2:07:22 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r203839 r203840 1 2016-07-28 Chris Dumez <cdumez@apple.com> 2 3 Parameter to table.deleteRow() / body.deleteRow() should be mandatory 4 https://bugs.webkit.org/show_bug.cgi?id=160307 5 6 Reviewed by Ryosuke Niwa. 7 8 Update existing test to reflect behavior change. 9 10 * fast/dom/non-numeric-values-numeric-parameters-expected.txt: 11 * fast/dom/script-tests/non-numeric-values-numeric-parameters.js: 12 1 13 2016-07-28 Commit Queue <commit-queue@webkit.org> 2 14 -
trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
r203836 r203840 35 35 PASS nonNumericPolicy('createHTMLSelectElement().item(x)') is 'any type allowed (but not omitted)' 36 36 PASS nonNumericPolicy('createHTMLTableElement().insertRow(x)') is 'any type allowed' 37 PASS nonNumericPolicy('createHTMLTableElement().deleteRow(x)') is 'any type allowed '37 PASS nonNumericPolicy('createHTMLTableElement().deleteRow(x)') is 'any type allowed (but not omitted)' 38 38 PASS nonNumericPolicy('createHTMLTableRowElement().insertCell(x)') is 'any type allowed' 39 39 PASS nonNumericPolicy('createHTMLTableRowElement().deleteCell(x)') is 'any type allowed (but not omitted)' 40 40 PASS nonNumericPolicy('createHTMLTableSectionElement().insertRow(x)') is 'any type allowed' 41 PASS nonNumericPolicy('createHTMLTableSectionElement().deleteRow(x)') is 'any type allowed '41 PASS nonNumericPolicy('createHTMLTableSectionElement().deleteRow(x)') is 'any type allowed (but not omitted)' 42 42 PASS nonNumericPolicy('document.createElement("textarea").setSelectionRange(x, 0)') is 'any type allowed' 43 43 PASS nonNumericPolicy('document.createElement("textarea").setSelectionRange(0, x)') is 'any type allowed' -
trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
r203836 r203840 256 256 257 257 shouldBe("nonNumericPolicy('createHTMLTableElement().insertRow(x)')", "'any type allowed'"); 258 shouldBe("nonNumericPolicy('createHTMLTableElement().deleteRow(x)')", "'any type allowed '");258 shouldBe("nonNumericPolicy('createHTMLTableElement().deleteRow(x)')", "'any type allowed (but not omitted)'"); 259 259 260 260 // HTMLTableRowElement … … 266 266 267 267 shouldBe("nonNumericPolicy('createHTMLTableSectionElement().insertRow(x)')", "'any type allowed'"); 268 shouldBe("nonNumericPolicy('createHTMLTableSectionElement().deleteRow(x)')", "'any type allowed '");268 shouldBe("nonNumericPolicy('createHTMLTableSectionElement().deleteRow(x)')", "'any type allowed (but not omitted)'"); 269 269 270 270 // HTMLInputElement -
trunk/LayoutTests/imported/w3c/ChangeLog
r203836 r203840 1 2016-07-28 Chris Dumez <cdumez@apple.com> 2 3 Parameter to table.deleteRow() / body.deleteRow() should be mandatory 4 https://bugs.webkit.org/show_bug.cgi?id=160307 5 6 Reviewed by Ryosuke Niwa. 7 8 Rebaseline W3C test now that more checks are passing. 9 10 * web-platform-tests/html/dom/interfaces-expected.txt: 11 1 12 2016-07-28 Chris Dumez <cdumez@apple.com> 2 13 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
r203836 r203840 2450 2450 PASS HTMLTableElement interface: attribute rows 2451 2451 PASS HTMLTableElement interface: operation insertRow(long) 2452 FAIL HTMLTableElement interface: operation deleteRow(long) assert_equals: property has wrong .length expected 1 but got 0 2452 PASS HTMLTableElement interface: operation deleteRow(long) 2453 2453 FAIL HTMLTableElement interface: attribute sortable assert_true: The prototype object must have a property "sortable" expected true got false 2454 2454 FAIL HTMLTableElement interface: operation stopSorting() assert_own_property: interface prototype object missing non-static operation expected property "stopSorting" missing … … 2479 2479 PASS HTMLTableElement interface: calling insertRow(long) on document.createElement("table") with too few arguments must throw TypeError 2480 2480 PASS HTMLTableElement interface: document.createElement("table") must inherit property "deleteRow" with the proper type (13) 2481 FAIL HTMLTableElement interface: calling deleteRow(long) on document.createElement("table") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () { 2482 fn.apply(obj, args); 2483 }" threw object "IndexSizeError (DOM Exception 1): The index is not in the..." ("IndexSizeError") expected object "TypeError" ("TypeError") 2481 PASS HTMLTableElement interface: calling deleteRow(long) on document.createElement("table") with too few arguments must throw TypeError 2484 2482 FAIL HTMLTableElement interface: document.createElement("table") must inherit property "sortable" with the proper type (14) assert_inherits: property "sortable" not found in prototype chain 2485 2483 FAIL HTMLTableElement interface: document.createElement("table") must inherit property "stopSorting" with the proper type (15) assert_inherits: property "stopSorting" not found in prototype chain … … 2536 2534 PASS HTMLTableSectionElement interface: attribute rows 2537 2535 PASS HTMLTableSectionElement interface: operation insertRow(long) 2538 FAIL HTMLTableSectionElement interface: operation deleteRow(long) assert_equals: property has wrong .length expected 1 but got 0 2536 PASS HTMLTableSectionElement interface: operation deleteRow(long) 2539 2537 PASS HTMLTableSectionElement interface: attribute align 2540 2538 PASS HTMLTableSectionElement interface: attribute ch … … 2547 2545 PASS HTMLTableSectionElement interface: calling insertRow(long) on document.createElement("tbody") with too few arguments must throw TypeError 2548 2546 PASS HTMLTableSectionElement interface: document.createElement("tbody") must inherit property "deleteRow" with the proper type (2) 2549 FAIL HTMLTableSectionElement interface: calling deleteRow(long) on document.createElement("tbody") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () { 2550 fn.apply(obj, args); 2551 }" threw object "IndexSizeError (DOM Exception 1): The index is not in the..." ("IndexSizeError") expected object "TypeError" ("TypeError") 2547 PASS HTMLTableSectionElement interface: calling deleteRow(long) on document.createElement("tbody") with too few arguments must throw TypeError 2552 2548 PASS HTMLTableSectionElement interface: document.createElement("tbody") must inherit property "align" with the proper type (3) 2553 2549 PASS HTMLTableSectionElement interface: document.createElement("tbody") must inherit property "ch" with the proper type (4) … … 2560 2556 PASS HTMLTableSectionElement interface: calling insertRow(long) on document.createElement("thead") with too few arguments must throw TypeError 2561 2557 PASS HTMLTableSectionElement interface: document.createElement("thead") must inherit property "deleteRow" with the proper type (2) 2562 FAIL HTMLTableSectionElement interface: calling deleteRow(long) on document.createElement("thead") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () { 2563 fn.apply(obj, args); 2564 }" threw object "IndexSizeError (DOM Exception 1): The index is not in the..." ("IndexSizeError") expected object "TypeError" ("TypeError") 2558 PASS HTMLTableSectionElement interface: calling deleteRow(long) on document.createElement("thead") with too few arguments must throw TypeError 2565 2559 PASS HTMLTableSectionElement interface: document.createElement("thead") must inherit property "align" with the proper type (3) 2566 2560 PASS HTMLTableSectionElement interface: document.createElement("thead") must inherit property "ch" with the proper type (4) … … 2573 2567 PASS HTMLTableSectionElement interface: calling insertRow(long) on document.createElement("tfoot") with too few arguments must throw TypeError 2574 2568 PASS HTMLTableSectionElement interface: document.createElement("tfoot") must inherit property "deleteRow" with the proper type (2) 2575 FAIL HTMLTableSectionElement interface: calling deleteRow(long) on document.createElement("tfoot") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () { 2576 fn.apply(obj, args); 2577 }" threw object "IndexSizeError (DOM Exception 1): The index is not in the..." ("IndexSizeError") expected object "TypeError" ("TypeError") 2569 PASS HTMLTableSectionElement interface: calling deleteRow(long) on document.createElement("tfoot") with too few arguments must throw TypeError 2578 2570 PASS HTMLTableSectionElement interface: document.createElement("tfoot") must inherit property "align" with the proper type (3) 2579 2571 PASS HTMLTableSectionElement interface: document.createElement("tfoot") must inherit property "ch" with the proper type (4) -
trunk/Source/WebCore/ChangeLog
r203839 r203840 1 2016-07-28 Chris Dumez <cdumez@apple.com> 2 3 Parameter to table.deleteRow() / body.deleteRow() should be mandatory 4 https://bugs.webkit.org/show_bug.cgi?id=160307 5 6 Reviewed by Ryosuke Niwa. 7 8 Parameter to table.deleteRow() / body.deleteRow() should be mandatory: 9 - https://html.spec.whatwg.org/multipage/tables.html#the-table-element 10 - https://html.spec.whatwg.org/multipage/tables.html#htmltablesectionelement 11 12 Firefox and Chrome agree with the specification. 13 14 No new tests, rebaselined existing test. 15 16 * html/HTMLTableElement.idl: 17 * html/HTMLTableSectionElement.idl: 18 1 19 2016-07-28 Commit Queue <commit-queue@webkit.org> 2 20 -
trunk/Source/WebCore/html/HTMLTableElement.idl
r203529 r203840 47 47 48 48 [RaisesException] HTMLElement insertRow(optional long index = -1); 49 [RaisesException] void deleteRow( optional long index = 0);49 [RaisesException] void deleteRow(long index); 50 50 }; 51 51 -
trunk/Source/WebCore/html/HTMLTableSectionElement.idl
r199969 r203840 28 28 readonly attribute HTMLCollection rows; 29 29 [RaisesException] HTMLElement insertRow(optional long index = -1); 30 [RaisesException] void deleteRow( optional long index = 0);30 [RaisesException] void deleteRow(long index); 31 31 }; 32 32 -
trunk/Source/WebInspectorUI/ChangeLog
r203836 r203840 1 2016-07-28 Chris Dumez <cdumez@apple.com> 2 3 Parameter to table.deleteRow() / body.deleteRow() should be mandatory 4 https://bugs.webkit.org/show_bug.cgi?id=160307 5 6 Reviewed by Ryosuke Niwa. 7 8 Update WebInspector accordingly. 9 10 * UserInterface/Models/NativeFunctionParameters.js: 11 1 12 2016-07-28 Chris Dumez <cdumez@apple.com> 2 13 -
trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js
r203836 r203840 963 963 964 964 HTMLTableElement: { 965 deleteRow: " [index]",965 deleteRow: "index", 966 966 insertRow: "[index]", 967 967 __proto__: null, … … 975 975 976 976 HTMLTableSectionElement: { 977 deleteRow: " [index]",977 deleteRow: "index", 978 978 insertRow: "[index]", 979 979 __proto__: null,
Note: See TracChangeset
for help on using the changeset viewer.