Changeset 203844 in webkit


Ignore:
Timestamp:
Jul 28, 2016 2:51:50 PM (8 years ago)
Author:
Matt Baker
Message:

Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView
https://bugs.webkit.org/show_bug.cgi?id=160093
<rdar://problem/27499300>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._positionHeaderViews):
Remove early return so that a header view in a hidden column will have
its width resized to zero, matching the column.

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r203843 r203844  
     12016-07-28  Matt Baker  <mattbaker@apple.com>
     2
     3        Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView
     4        https://bugs.webkit.org/show_bug.cgi?id=160093
     5        <rdar://problem/27499300>
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        * UserInterface/Views/DataGrid.js:
     10        (WebInspector.DataGrid.prototype._positionHeaderViews):
     11        Remove early return so that a header view in a hidden column will have
     12        its width resized to zero, matching the column.
     13
    1142016-07-28  Johan K. Jensen  <johan_jensen@apple.com>
    215
  • trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js

    r203114 r203844  
    985985    _positionHeaderViews()
    986986    {
    987         let visibleHeaderViews = false;
    988         for (let column of this.columns.values()) {
    989             if (column["headerView"] && !column["hidden"]) {
    990                 visibleHeaderViews = true;
    991                 break;
    992             }
    993         }
    994 
    995         if (!visibleHeaderViews)
    996             return;
    997 
    998987        let left = 0;
    999988        let headerViews = [];
Note: See TracChangeset for help on using the changeset viewer.