Changeset 203902 in webkit

Timestamp:

Jul 29, 2016 10:19:17 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Crash Log Clobbering on Unbound Crashes
​https://bugs.webkit.org/show_bug.cgi?id=160198
<rdar://problem/27472618>

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-07-29
Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs): Fix header order.

• Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.

Location:

trunk

Files:

• LayoutTests/fast/harness/results.html (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitpy/common/system/crashlogs.py (modified) (1 diff)
• Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py (modified) (1 diff)

trunk/LayoutTests/fast/harness/results.html

@@ -273 +273 @@
 function stripExtension(test)
 {
+    // Temporary fix, also in Tools/Scripts/webkitpy/layout_tests/constrollers/test_result_writer.py, line 95.
+    // FIXME: Refactor to avoid confusing reference to both test and process names.
+    if (splitExtension(test)[1].length > 5)
+        return test;
     return splitExtension(test)[0];
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2016-07-29  Jonathan Bedard  <jbedard@apple.com>
+
+        Crash Log Clobbering on Unbound Crashes
+        https://bugs.webkit.org/show_bug.cgi?id=160198
+        <rdar://problem/27472618>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/common/system/crashlogs.py:
+        (CrashLogs): Fix header order.
+        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
+        (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
+
 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
 

trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py

@@ -29 +29 @@
 
 import codecs
+import datetime
 import re
-import datetime
 
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

@@ -90 +90 @@
         fs = self._filesystem
         output_filename = fs.join(self._root_output_dir, self._test_name)
+
+        # Temporary fix, also in LayoutTests/fast/harness/results.html, line 275.
+        # FIXME: Refactor to avoid confusing reference to both test and process names.
+        if len(fs.splitext(output_filename)[1]) - 1 > 5:
+            return output_filename + modifier
         return fs.splitext(output_filename)[0] + modifier