Changeset 203908 in webkit

Timestamp:

Jul 29, 2016 11:40:27 AM (8 years ago)

Author:

Matt Baker

Message:

Web Inspector: Assertion in NetworkGridContentView when updating data grid for the first time
​https://bugs.webkit.org/show_bug.cgi?id=160330
<rdar://problem/27600905>

Reviewed by Brian Burg.

When the first grid node is added, a view layout and current time update
are scheduled. A view layout occurring before the current time is updated
should be skipped, since the ruler end time hasn't been set.

• UserInterface/Views/NetworkGridContentView.js:

(WebInspector.NetworkGridContentView.prototype.layout):
Skip layout until current time is updated.
(WebInspector.NetworkGridContentView.prototype._update):
Remove unused variables startTime and endTime. Don't force a layout
if the elapsed time is zero.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/NetworkGridContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-07-29  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Assertion in NetworkGridContentView when updating data grid for the first time
+        https://bugs.webkit.org/show_bug.cgi?id=160330
+        <rdar://problem/27600905>
+
+        Reviewed by Brian Burg.
+
+        When the first grid node is added, a view layout and current time update
+        are scheduled. A view layout occurring before the current time is updated
+        should be skipped, since the ruler end time hasn't been set.
+
+        * UserInterface/Views/NetworkGridContentView.js:
+        (WebInspector.NetworkGridContentView.prototype.layout):
+        Skip layout until current time is updated.
+        (WebInspector.NetworkGridContentView.prototype._update):
+        Remove unused variables `startTime` and `endTime`. Don't force a layout
+        if the elapsed time is zero.
+
 2016-07-28  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js

@@ -182 +182 @@
         this._timelineRuler.startTime = this.zeroTime;
 
+        if (this.startTime >= this.endTime)
+            return;
+
         for (let dataGridNode of this._dataGrid.children)
             dataGridNode.refreshGraph();
@@ -288 +291 @@
         console.assert(this._scheduledCurrentTimeUpdateIdentifier);
 
-        let startTime = this.startTime;
-        let currentTime = this.currentTime;
-        let endTime = this.endTime;
-        let timespanSinceLastUpdate = (timestamp - this._lastUpdateTimestamp) / 1000 || 0;
-
-        currentTime += timespanSinceLastUpdate;
-
-        this._timelineRuler.endTime = currentTime;
+        if (!isNaN(this._lastUpdateTimestamp)) {
+            let timespanSinceLastUpdate = (timestamp - this._lastUpdateTimestamp) / 1000 || 0;
+            this._timelineRuler.endTime = this.currentTime + timespanSinceLastUpdate;
+
+            this.updateLayout();
+        }
+
         this._lastUpdateTimestamp = timestamp;
-        this.updateLayout();
-
         this._scheduledCurrentTimeUpdateIdentifier = requestAnimationFrame(this._updateCallback);
     }