Changeset 203910 in webkit

Timestamp:

Jul 29, 2016 11:47:52 AM (8 years ago)

Author:

mark.lam@apple.com

Message:

Remove an unused line of code.
​https://bugs.webkit.org/show_bug.cgi?id=160350

Reviewed by Simon Fraser.

No new tests because there's no behavior change. Just removing dead code.

SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun.
Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun
was introduced in ​https://trac.webkit.org/changeset/61393, but was later
rendered unused in ​https://trac.webkit.org/changeset/62099 because we
switched to using paintTextWithShadows() with the selectionStyle. Hence,
selectionTextRun can be removed.

• rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintText):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/svg/SVGInlineTextBox.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-29  Mark Lam  <mark.lam@apple.com>
+
+        Remove an unused line of code.
+        https://bugs.webkit.org/show_bug.cgi?id=160350
+
+        Reviewed by Simon Fraser.
+
+        No new tests because there's no behavior change.  Just removing dead code.
+
+        SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun. 
+        Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun
+        was introduced in https://trac.webkit.org/changeset/61393, but was later
+        rendered unused in https://trac.webkit.org/changeset/62099 because we
+        switched to using paintTextWithShadows() with the selectionStyle.  Hence,
+        selectionTextRun can be removed.
+
+        * rendering/svg/SVGInlineTextBox.cpp:
+        (WebCore::SVGInlineTextBox::paintText):
+
 2016-07-29  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp

@@ -613 +613 @@
         SVGResourcesCache::clientStyleChanged(parent()->renderer(), StyleDifferenceRepaint, *selectionStyle);
 
-    TextRun selectionTextRun = constructTextRun(selectionStyle, fragment);
     paintTextWithShadows(context, selectionStyle, textRun, fragment, startPosition, endPosition);