Changeset 203955 in webkit
- Timestamp:
- Jul 31, 2016 1:02:54 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r203952 r203955 1 2016-07-31 Nan Wang <n_wang@apple.com> 2 3 AX: Add a check for touch event listener on iOS accessibility object 4 https://bugs.webkit.org/show_bug.cgi?id=160388 5 6 Reviewed by Chris Fleizach. 7 8 * accessibility/ios-simulator/has-touch-event-listener-expected.txt: Added. 9 * accessibility/ios-simulator/has-touch-event-listener.html: Added. 10 1 11 2016-07-30 Mark Lam <mark.lam@apple.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r203951 r203955 1 2016-07-31 Nan Wang <n_wang@apple.com> 2 3 AX: Add a check for touch event listener on iOS accessibility object 4 https://bugs.webkit.org/show_bug.cgi?id=160388 5 6 Reviewed by Chris Fleizach. 7 8 dispatchTouchEvent() is not working correctly within AXPress() sometimes. Need to 9 investigate it more in the future. Now, adding a check for the touch event listener 10 on the object's node so that iOS can handle dispatching the touch event instead. 11 12 Test: accessibility/ios-simulator/has-touch-event-listener.html 13 14 * accessibility/AccessibilityObject.h: 15 * accessibility/ios/AccessibilityObjectIOS.mm: 16 (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): 17 (WebCore::AccessibilityObject::hasTouchEventListener): 18 * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: 19 (appendStringToResult): 20 (-[WebAccessibilityObjectWrapper _accessibilityHasTouchEventListener]): 21 (-[WebAccessibilityObjectWrapper _accessibilityValueIsAutofilled]): 22 1 23 2016-07-30 Chris Dumez <cdumez@apple.com> 2 24 -
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
r203711 r203955 923 923 UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); 924 924 925 // FIXME: dispatchTouchEvent() is not dispatching the touch event correctly. 925 926 bool dispatchedTouchEvent = dispatchTouchEvent(); 926 927 if (!dispatchedTouchEvent) -
trunk/Source/WebCore/accessibility/AccessibilityObject.h
r203711 r203955 1041 1041 #if PLATFORM(IOS) 1042 1042 int accessibilityPasswordFieldLength(); 1043 bool hasTouchEventListener() const; 1043 1044 #endif 1044 1045 -
trunk/Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm
r174898 r203955 27 27 #import "AccessibilityObject.h" 28 28 #import "AccessibilityRenderObject.h" 29 #import "EventNames.h" 29 30 #import "HTMLInputElement.h" 30 31 #import "RenderObject.h" … … 81 82 return DefaultBehavior; 82 83 } 83 84 85 bool AccessibilityObject::hasTouchEventListener() const 86 { 87 for (Node* node = this->node(); node; node = node->parentNode()) { 88 if (node->hasEventListeners(eventNames().touchstartEvent) || node->hasEventListeners(eventNames().touchendEvent)) 89 return true; 90 } 91 return false; 92 } 93 84 94 } // WebCore 85 95 -
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
r203538 r203955 950 950 } 951 951 952 - (BOOL)_accessibilityHasTouchEventListener 953 { 954 if (![self _prepareAccessibilityCall]) 955 return NO; 956 957 return m_object->hasTouchEventListener(); 958 } 959 952 960 - (BOOL)_accessibilityValueIsAutofilled 953 961 { -
trunk/Tools/ChangeLog
r203942 r203955 1 2016-07-31 Nan Wang <n_wang@apple.com> 2 3 AX: Add a check for touch event listener on iOS accessibility object 4 https://bugs.webkit.org/show_bug.cgi?id=160388 5 6 Reviewed by Chris Fleizach. 7 8 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: 9 (AccessibilityUIElement::boolAttributeValue): 10 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: 11 (WTR::AccessibilityUIElement::boolAttributeValue): 12 1 13 2016-07-30 Manuel Rego Casasnovas <rego@igalia.com> 2 14 -
trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
r201568 r203955 96 96 - (UIAccessibilityTraits)_axContainedByFieldsetTrait; 97 97 - (id)_accessibilityFieldsetAncestor; 98 - (BOOL)_accessibilityHasTouchEventListener; 98 99 99 100 // TextMarker related … … 668 669 bool AccessibilityUIElement::boolAttributeValue(JSStringRef attribute) 669 670 { 671 if (JSStringIsEqualToUTF8CString(attribute, "AXHasTouchEventListener")) 672 return [m_element _accessibilityHasTouchEventListener]; 670 673 return false; 671 674 } -
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
r201568 r203955 73 73 - (UIAccessibilityTraits)_axContainedByFieldsetTrait; 74 74 - (id)_accessibilityFieldsetAncestor; 75 - (BOOL)_accessibilityHasTouchEventListener; 75 76 76 77 // TextMarker related … … 380 381 bool AccessibilityUIElement::boolAttributeValue(JSStringRef attribute) 381 382 { 383 if (JSStringIsEqualToUTF8CString(attribute, "AXHasTouchEventListener")) 384 return [m_element _accessibilityHasTouchEventListener]; 382 385 return false; 383 386 }
Note: See TracChangeset
for help on using the changeset viewer.