Changeset 204033 in webkit

Timestamp:

Aug 2, 2016 12:11:27 PM (8 years ago)

Author:

Chris Dumez

Message:

Kill [StrictTypeChecking] IDL extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=160382

Reviewed by Darin Adler.

Kill [StrictTypeChecking] IDL extended attribute. Its only remaining
use was on DOMString parameters for a few CanvasRenderingContext2D
operations in order to work around a bug in our overload resolution.

However, as of r204028, we implement the Web IDL overload resolution
algorithm and [StrictTypeChecking] is now a no-op and is no longer
needed.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheckExpression):

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestTypedefs.idl:
• html/canvas/CanvasRenderingContext2D.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (1 diff)
• bindings/scripts/IDLAttributes.txt (modified) (1 diff)
• bindings/scripts/test/TestObj.idl (modified) (1 diff)
• bindings/scripts/test/TestTypedefs.idl (modified) (1 diff)
• html/canvas/CanvasRenderingContext2D.idl (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-08-02  Chris Dumez  <cdumez@apple.com>
+
+        Kill [StrictTypeChecking] IDL extended attribute
+        https://bugs.webkit.org/show_bug.cgi?id=160382
+
+        Reviewed by Darin Adler.
+
+        Kill [StrictTypeChecking] IDL extended attribute. Its only remaining
+        use was on DOMString parameters for a few CanvasRenderingContext2D
+        operations in order to work around a bug in our overload resolution.
+
+        However, as of r204028, we implement the Web IDL overload resolution
+        algorithm and [StrictTypeChecking] is now a no-op and is no longer
+        needed.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateParametersCheckExpression):
+        * bindings/scripts/IDLAttributes.txt:
+        * bindings/scripts/test/TestObj.idl:
+        * bindings/scripts/test/TestTypedefs.idl:
+        * html/canvas/CanvasRenderingContext2D.idl:
+
 2016-08-02  Frederic Wang  <fwang@igalia.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -1957 +1957 @@
         my $type = $parameter->type;
 
-        # For DOMString with StrictTypeChecking only Null, Undefined and Object
-        # are accepted for compatibility. Otherwise, no restrictions are made to
-        # match the non-overloaded behavior.
-        # FIXME: Implement WebIDL overload resolution algorithm.
-        if ($type eq "DOMString" || $codeGenerator->IsEnumType($type)) {
-            if ($parameter->extendedAttributes->{"StrictTypeChecking"}) {
-                push(@andExpression, "(${value}.isUndefinedOrNull() || ${value}.isString() || ${value}.isObject())");
-                $usedArguments{$parameterIndex} = 1;
-            }
-        } elsif ($codeGenerator->IsCallbackInterface($parameter->type)) {
+        if ($codeGenerator->IsCallbackInterface($parameter->type)) {
             # For Callbacks only checks if the value is null or object.
             if ($codeGenerator->IsFunctionOnlyCallbackInterface($parameter->type)) {

trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt

@@ -121 +121 @@
 SetterCallWith=ScriptExecutionContext|ScriptState|ScriptArguments|CallStack|ActiveWindow|FirstWindow
 SkipVTableValidation
-StrictTypeChecking
 SuppressToJSObject
 TreatNullAs=EmptyString

trunk/Source/WebCore/bindings/scripts/test/TestObj.idl

@@ -252 +252 @@
 #if defined(TESTING_JS)
     // Overloads
-    void    overloadedMethod(TestObj? objArg, [StrictTypeChecking] DOMString strArg);
+    void    overloadedMethod(TestObj? objArg, DOMString strArg);
     void    overloadedMethod(TestObj? objArg, optional long longArg);
-    void    overloadedMethod([StrictTypeChecking] DOMString strArg);
+    void    overloadedMethod(DOMString strArg);
     void    overloadedMethod(long longArg);
     void    overloadedMethod(TestCallback callback);

trunk/Source/WebCore/bindings/scripts/test/TestTypedefs.idl

@@ -43 +43 @@
     void func(optional ARRAY_OF_LONGS x = []);
 
-    void setShadow(DOUBLE width, DOUBLE height, unrestricted float blur, [StrictTypeChecking] optional STRING color, optional DOUBLE alpha);
+    void setShadow(DOUBLE width, DOUBLE height, unrestricted float blur, optional STRING color, optional DOUBLE alpha);
 
     ULONGLONG methodWithSequenceArg(sequence<SCRIPT_VALUE> sequenceArg);

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl

@@ -127 +127 @@
     void strokeText(DOMString text, unrestricted float x, unrestricted float y, optional unrestricted float maxWidth);
 
-    void setStrokeColor([StrictTypeChecking] DOMString color, optional unrestricted float alpha);
+    void setStrokeColor(DOMString color, optional unrestricted float alpha);
     void setStrokeColor(unrestricted float grayLevel, optional float alpha = 1);
     void setStrokeColor(unrestricted float r, unrestricted float g, unrestricted float b, unrestricted float a);
     void setStrokeColor(unrestricted float c, unrestricted float m, unrestricted float y, unrestricted float k, unrestricted float a);
 
-    void setFillColor([StrictTypeChecking] DOMString color, optional unrestricted float alpha);
+    void setFillColor(DOMString color, optional unrestricted float alpha);
     void setFillColor(unrestricted float grayLevel, optional unrestricted float alpha = 1);
     void setFillColor(unrestricted float r, unrestricted float g, unrestricted float b, unrestricted float a);
@@ -161 +161 @@
 
     void setShadow(unrestricted float width, unrestricted float height, unrestricted float blur, 
-        [StrictTypeChecking] optional DOMString color, optional unrestricted float alpha);
+        optional DOMString color, optional unrestricted float alpha);
     void setShadow(unrestricted float width, unrestricted float height, unrestricted float blur, unrestricted float grayLevel, 
         optional unrestricted float alpha = 1);