Changeset 20408 in webkit


Ignore:
Timestamp:
Mar 22, 2007 3:08:49 PM (17 years ago)
Author:
spadma
Message:

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
​http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
Location:
S60/trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • S60/trunk/WebCore/ChangeLog

    r20117 r20408  
     12007-03-22  spadma
     2
     3        Reviewed by Zalan.
     4        DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
     5        http://bugs.webkit.org/show_bug.cgi?id=13162
     6
     7        * BrowserView/inc/WebKitLoader.h:
     8        * BrowserView/src/WebKitLoader.cpp:
     9        (CWebKitLoader::~CWebKitLoader):
     10        (CWebKitLoader::SetPageUrlL):
     11        * BrowserView/src/webkitbridge.cpp:
     12        (CWebKitBridge::SaveFormData):
     13
     14
    1152007-03-09   borges   <mario.g.borges@nokia.com>
    216

  • S60/trunk/WebCore/bridge/WebCoreBridge.cpp

    r19406 r20408  
    353353void CWebCoreBridge::SaveDocumentState()
    354354{
    355   // Save persisted form data
    356   if (iPart->FormValues()){
    357     Client().SaveFormData(*iPart->FormValues());
    358     iPart->clearRecordedFormValues();
    359   }
    360355// ### NOT IMPLEMENTED document state save/restore
    361356/*

  • S60/trunk/WebCore/kwq/KWQKHTMLPart.cpp

    r19282 r20408  
    797797    formData.Close();
    798798    }
    799 //    clearRecordedFormValues();
     799     // Save persisted form data
     800    if (FormValues()){
     801        _bridge->Client().SaveFormData(*FormValues());
     802    }
     803    clearRecordedFormValues();
    800804
    801805//    KWQ_UNBLOCK_EXCEPTIONS;

  • S60/trunk/WebKit/BrowserView/inc/WebKitLoader.h

    r20035 r20408  
    281281        HBufC* PageUrl() { return iPageUrl; }
    282282
    283         /**
    284         * PageUrl
    285         *
    286         * @since 3.1
    287         * @param
    288         * @return
    289         */
    290         HBufC* PrevPageUrl() { return iPrevPageUrl; }
    291283       
    292284        /**
    … …  
    499491        //
    500492        HBufC*                  iPageUrl;              // owned
    501         //
    502         HBufC*                  iPrevPageUrl;              // owned
    503493
    504494        HBufC*                  iReferrerUrl;              // owned

  • S60/trunk/WebKit/BrowserView/src/WebKitLoader.cpp

    r20155 r20408  
    198198    delete iPageUrl;
    199199    //
    200     delete iPrevPageUrl;
    201     //
    202200    delete iReferrerUrl;
    203201    //
    … …  
    821819    const TDesC& aResponseUrl )
    822820    {
    823     delete iPrevPageUrl;
    824     iPrevPageUrl = iPageUrl;
    825821    iPageUrl = aResponseUrl.AllocL();
    826822    }

  • S60/trunk/WebKit/BrowserView/src/webkitbridge.cpp

    r19501 r20408  
    723723    TRAP_IGNORE(
    724724        CFormDataManager* formManager = iFrame->WebKitView().WebKitControl().FormDataManagerL();
    725         if (formManager)
     725        if (formManager && iLoader->PageUrl())
    726726            {
    727             // closeURL is now called when receiving the response headers, not when submitting the form
    728             __ASSERT_DEBUG( iLoader->PrevPageUrl(), User::Panic( _L("WebKitLoader"), KErrGeneral ) );
    729             TPtrC url(iLoader->PrevPageUrl()->Des());
    730             formManager->SaveDataL(url,aFormValues);
     727            formManager->SaveDataL(*iLoader->PageUrl(),aFormValues);
    731728            }
    732729        );

  • S60/trunk/WebKit/ChangeLog

    r20406 r20408  
     12007-03-22  spadma
     2
     3        Reviewed by Zalan.
     4        DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
     5        http://bugs.webkit.org/show_bug.cgi?id=13162
     6
     7        * BrowserView/inc/WebKitLoader.h:
     8        * BrowserView/src/WebKitLoader.cpp:
     9        (CWebKitLoader::~CWebKitLoader):
     10        (CWebKitLoader::SetPageUrlL):
     11        * BrowserView/src/webkitbridge.cpp:
     12        (CWebKitBridge::SaveFormData):
     13
    1142007-03-21  vbradley  <vincent.bradley@nokia.com>
    215
Note: See TracChangeset for help on using the changeset viewer.