Changeset 204171 in webkit


Ignore:
Timestamp:
Aug 5, 2016 9:22:09 AM (8 years ago)
Author:
commit-queue@webkit.org
Message:

[Fetch API] Response.blob should not assert in case the created blob is empty
https://bugs.webkit.org/show_bug.cgi?id=160592

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-05
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/request/request-consume-expected.txt:
  • web-platform-tests/fetch/api/request/request-consume.html: Adding response with empty blob test.

Source/WebCore:

Covered bu updated test.

  • Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::takeAsBlob): Removing assertion as a response may have a body but with no data in it.

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/imported/w3c/ChangeLog

    r204166 r204171  
     12016-08-05  Youenn Fablet  <youenn@apple.com>
     2
     3        [Fetch API] Response.blob should not assert in case the created blob is empty
     4        https://bugs.webkit.org/show_bug.cgi?id=160592
     5
     6        Reviewed by Alex Christensen.
     7
     8        * web-platform-tests/fetch/api/request/request-consume-expected.txt:
     9        * web-platform-tests/fetch/api/request/request-consume.html: Adding response with empty blob test.
     10
    1112016-08-05  Commit Queue  <commit-queue@webkit.org>
    212
  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt

    r198133 r204171  
    99PASS Consume blob response's body as json
    1010PASS Consume blob response's body as arrayBuffer
     11PASS Consume blob response's body as blob (empty blob as input)
    1112PASS Consume JSON from text: '"null"'
    1213PASS Consume JSON from text: '"1"'
  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume.html

    r200309 r204171  
    9292    checkBlobResponseBody(blob, textData, "json", checkBodyJSON);
    9393    checkBlobResponseBody(blob, textData, "arrayBuffer", checkBodyArrayBuffer);
     94    checkBlobResponseBody(new Blob([""]), "", "blob (empty blob as input)", checkBodyBlob);
    9495
    9596    var goodJSONValues = ["null", "1", "true", "\"string\""];
  • trunk/Source/WebCore/ChangeLog

    r204166 r204171  
     12016-08-05  Youenn Fablet  <youenn@apple.com>
     2
     3        [Fetch API] Response.blob should not assert in case the created blob is empty
     4        https://bugs.webkit.org/show_bug.cgi?id=160592
     5
     6        Reviewed by Alex Christensen.
     7
     8        Covered bu updated test.
     9
     10        * Modules/fetch/FetchBodyConsumer.cpp:
     11        (WebCore::FetchBodyConsumer::takeAsBlob): Removing assertion as a response may have a body but with no data in it.
     12
    1132016-08-05  Commit Queue  <commit-queue@webkit.org>
    214
  • trunk/Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp

    r203767 r204171  
    118118Ref<Blob> FetchBodyConsumer::takeAsBlob()
    119119{
    120     ASSERT(m_buffer);
    121120    if (!m_buffer)
    122121        return Blob::create();
Note: See TracChangeset for help on using the changeset viewer.