Changeset 204244 in webkit

Timestamp:

Aug 7, 2016 12:40:59 PM (8 years ago)

Author:

Matt Baker

Message:

REGRESSION (r201245): switching between Computed and Visual Styles panels causes internal error
​https://bugs.webkit.org/show_bug.cgi?id=160604
<rdar://problem/27723416>

Reviewed by Timothy Hatcher.

• UserInterface/Views/StyleDetailsPanel.js:

(WebInspector.StyleDetailsPanel.prototype.shown):
Only perform a layout if needed. Subclasses access node style
data during layout, which may not exist yet.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/StyleDetailsPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-08-07  Matt Baker  <mattbaker@apple.com>
+
+        REGRESSION (r201245): switching between Computed and Visual Styles panels causes internal error
+        https://bugs.webkit.org/show_bug.cgi?id=160604
+        <rdar://problem/27723416>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/StyleDetailsPanel.js:
+        (WebInspector.StyleDetailsPanel.prototype.shown):
+        Only perform a layout if needed. Subclasses access node style
+        data during layout, which may not exist yet.
+
 2016-08-06  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js

@@ -63 +63 @@
 
         // FIXME: remove once <https://webkit.org/b/150741> is fixed.
-        this.needsLayout();
+        this.updateLayoutIfNeeded();
     }