Changeset 204621 in webkit

Timestamp:

Aug 18, 2016 6:07:45 PM (8 years ago)

Author:

Chris Dumez

Message:

[iOS] Network Processes & Database processes do not exit promptly
​https://bugs.webkit.org/show_bug.cgi?id=160978
<rdar://problem/27914081>

Reviewed by Anders Carlsson.

Network Processes & Database processes do not exit promptly. They hang
for 10 seconds until they log the following message:

com.apple.WebKit.Networking: (WebKit) #WK: Exiting process early due to unacknowledged closed-connection

Then forcefully call exit(0).

To address the issue, we now call ChildProcess::stopRunLoop() instead
of RunLoop::current().stop(). stopRunLoop() works as expected on iOS
after r202723.

There is no impact on Mac because stopRunLoop() calls
RunLoop::current().stop().

• DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::didReceiveInvalidMessage):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• DatabaseProcess/DatabaseProcess.cpp (modified) (2 diffs)
• NetworkProcess/NetworkProcess.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-08-18  Chris Dumez  <cdumez@apple.com>
+
+        [iOS] Network Processes & Database processes do not exit promptly
+        https://bugs.webkit.org/show_bug.cgi?id=160978
+        <rdar://problem/27914081>
+
+        Reviewed by Anders Carlsson.
+
+        Network Processes & Database processes do not exit promptly. They hang
+        for 10 seconds until they log the following message:
+        > com.apple.WebKit.Networking: (WebKit) #WK: Exiting process early due to unacknowledged closed-connection
+
+        Then forcefully call exit(0).
+
+        To address the issue, we now call ChildProcess::stopRunLoop() instead
+        of RunLoop::current().stop(). stopRunLoop() works as expected on iOS
+        after r202723.
+
+        There is no impact on Mac because stopRunLoop() calls
+        RunLoop::current().stop().
+
+        * DatabaseProcess/DatabaseProcess.cpp:
+        (WebKit::DatabaseProcess::didClose):
+        (WebKit::DatabaseProcess::didReceiveInvalidMessage):
+        * NetworkProcess/NetworkProcess.cpp:
+        (WebKit::NetworkProcess::didClose):
+        (WebKit::NetworkProcess::didReceiveInvalidMessage):
+
 2016-08-18  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp

@@ -77 +77 @@
 void DatabaseProcess::didClose(IPC::Connection&)
 {
-    RunLoop::current().stop();
+    stopRunLoop();
 }
 
@@ -93 +93 @@
 void DatabaseProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
 {
-    RunLoop::current().stop();
+    stopRunLoop();
 }
 

trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp

@@ -158 +158 @@
 {
     // The UIProcess just exited.
-    RunLoop::current().stop();
+    stopRunLoop();
 }
 
 void NetworkProcess::didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference)
 {
-    RunLoop::current().stop();
+    stopRunLoop();
 }