Changeset 204756 in webkit
- Timestamp:
- Aug 22, 2016 10:12:51 PM (8 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r204728 r204756 1 2016-08-22 Dewei Zhu <dewei_zhu@apple.com> 2 3 Stop python icon bouncing in the dock while running browser benchmarks. 4 https://bugs.webkit.org/show_bug.cgi?id=161066 5 6 Reviewed by Ryosuke Niwa. 7 8 Bouncing python icon may impact browser benchmark results. 9 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: 10 (OSXBrowserDriver.prepare_env): 11 (OSXBrowserDriver.restore_env): 12 1 13 2016-08-22 Simon Fraser <simon.fraser@apple.com> 2 14 -
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py
r199805 r204756 5 5 6 6 from browser_driver import BrowserDriver 7 from webkitpy.benchmark_runner.utils import write_defaults 7 8 8 9 … … 18 19 from Quartz import CGWarpMouseCursorPosition 19 20 CGWarpMouseCursorPosition((10, 0)) 21 self.updated_dock_animation_defaults = write_defaults('com.apple.dock', 'launchanim', False) 22 if self.updated_dock_animation_defaults: 23 self._terminate_processes('Dock') 20 24 21 25 def restore_env(self): 22 pass 26 if self.updated_dock_animation_defaults: 27 write_defaults('com.apple.dock', 'launchanim', True) 28 self._terminate_processes('Dock') 23 29 24 30 def close_browsers(self): -
trunk/Tools/Scripts/webkitpy/benchmark_runner/utils.py
r202362 r204756 46 46 47 47 48 def write_defaults(domain, key, value): 49 # Returns whether the key in the domain is updated 50 from Foundation import NSUserDefaults 51 defaults = NSUserDefaults.standardUserDefaults() 52 defaults_for_domain = defaults.persistentDomainForName_(domain) 53 if not defaults_for_domain: 54 return False 55 old_value = defaults_for_domain.get(key) 56 if old_value == value: 57 return False 58 mutable_defaults_for_domain = defaults_for_domain.mutableCopy() 59 mutable_defaults_for_domain[key] = value 60 defaults.setPersistentDomain_forName_(mutable_defaults_for_domain, domain) 61 defaults.synchronize() 62 return True 63 64 48 65 # Borrow this code from 49 66 # 'http://stackoverflow.com/questions/2281850/timeout-function-if-it-takes-too-long-to-finish'
Note: See TracChangeset
for help on using the changeset viewer.