Changeset 204840 in webkit

Timestamp:

Aug 23, 2016 10:32:52 AM (8 years ago)

Author:

sbarati@apple.com

Message:

JIT::updateTopCallframe() in the baseline JIT should use PC instead of PC+1
​https://bugs.webkit.org/show_bug.cgi?id=158955

Reviewed by Mark Lam.

This will make the baseline JIT consistent with the rest of the tiers.

• jit/JITInlines.h:

(JSC::JIT::updateTopCallFrame):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JITInlines.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-08-23  Saam Barati  <sbarati@apple.com>
+
+        JIT::updateTopCallframe() in the baseline JIT should use PC instead of PC+1
+        https://bugs.webkit.org/show_bug.cgi?id=158955
+
+        Reviewed by Mark Lam.
+
+        This will make the baseline JIT consistent with the rest of the tiers.
+
+        * jit/JITInlines.h:
+        (JSC::JIT::updateTopCallFrame):
+
 2016-08-22  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/JavaScriptCore/jit/JITInlines.h

@@ -138 +138 @@
     ASSERT(static_cast<int>(m_bytecodeOffset) >= 0);
 #if USE(JSVALUE32_64)
-    Instruction* instruction = m_codeBlock->instructions().begin() + m_bytecodeOffset + 1; 
+    Instruction* instruction = m_codeBlock->instructions().begin() + m_bytecodeOffset; 
     uint32_t locationBits = CallSiteIndex(instruction).bits();
 #else
-    uint32_t locationBits = CallSiteIndex(m_bytecodeOffset + 1).bits();
+    uint32_t locationBits = CallSiteIndex(m_bytecodeOffset).bits();
 #endif
     store32(TrustedImm32(locationBits), intTagFor(CallFrameSlot::argumentCount));