Changeset 204936 in webkit
- Timestamp:
- Aug 24, 2016 2:58:33 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r204935 r204936 1 2016-08-24 Chris Dumez <cdumez@apple.com> 2 3 Assertion hit: ASSERT(!m_parserScheduler) in ~HTMLDocumentParser() 4 https://bugs.webkit.org/show_bug.cgi?id=161083 5 <rdar://problem/27986937> 6 7 Reviewed by Darin Adler. 8 9 Unskip html/browsers/browsing-the-web/unloading-documents/004.html as 10 it is no longer crashing. 11 12 * TestExpectations: 13 1 14 2016-08-24 Eric Carlson <eric.carlson@apple.com> 2 15 -
trunk/LayoutTests/TestExpectations
r204915 r204936 237 237 # Promises/A+ 2.3.3 has many tests and it sometimes exceeds the time limit. 238 238 webkit.org/b/136878 js/promises-tests/promises-tests-2-3-3.html [ Slow ] 239 240 webkit.org/b/161083 [ Debug ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html [ Crash ]241 239 242 240 # Resource files not in resources folder -
trunk/Source/WebCore/ChangeLog
r204935 r204936 1 2016-08-24 Chris Dumez <cdumez@apple.com> 2 3 Assertion hit: ASSERT(!m_parserScheduler) in ~HTMLDocumentParser() 4 https://bugs.webkit.org/show_bug.cgi?id=161083 5 <rdar://problem/27986937> 6 7 Reviewed by Darin Adler. 8 9 Call cancelParsing() right before re-creating the new parser in 10 Document::implicitOpen(). We would previously call removeChildren() 11 in between which is was an issue because it can cause JS to be 12 executed and therefore the parser to be re-created after we have 13 cancelled parsing. 14 15 No new tests, unskipped html/browsers/browsing-the-web/unloading-documents/004.html 16 which was consistently crashing. 17 18 * dom/Document.cpp: 19 (WebCore::Document::implicitOpen): 20 1 21 2016-08-24 Eric Carlson <eric.carlson@apple.com> 2 22 -
trunk/Source/WebCore/dom/Document.cpp
r204732 r204936 2614 2614 void Document::implicitOpen() 2615 2615 { 2616 removeChildren(); 2617 2618 setCompatibilityMode(DocumentCompatibilityMode::NoQuirksMode); 2619 2616 2620 cancelParsing(); 2617 2618 removeChildren();2619 2620 setCompatibilityMode(DocumentCompatibilityMode::NoQuirksMode);2621 2622 2621 m_parser = createParser(); 2623 2622 setParsing(true);
Note: See TracChangeset
for help on using the changeset viewer.