Changeset 204938 in webkit


Ignore:
Timestamp:
Aug 24, 2016 3:25:17 PM (8 years ago)
Author:
n_wang@apple.com
Message:

AX: VoiceOver on iOS ignores aria-checked on menuitemradio and menuitemcheckbox
​https://bugs.webkit.org/show_bug.cgi?id=161118

Reviewed by Chris Fleizach.

Source/WebCore:

Added checkboxOrRadioValue and toggle trait to menuitemradio and menuitemcheckbox.

Test: accessibility/ios-simulator/menuitem-checked.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):

LayoutTests:

  • accessibility/ios-simulator/menuitem-checked-expected.txt: Added.
  • accessibility/ios-simulator/menuitem-checked.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r204937 r204938  
     12016-08-24  Nan Wang  <n_wang@apple.com>
     2
     3        AX: VoiceOver on iOS ignores aria-checked on menuitemradio and menuitemcheckbox
     4        https://bugs.webkit.org/show_bug.cgi?id=161118
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/ios-simulator/menuitem-checked-expected.txt: Added.
     9        * accessibility/ios-simulator/menuitem-checked.html: Added.
     10
    1112016-08-24  Jiewen Tan  <jiewen_tan@apple.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r204936 r204938  
     12016-08-24  Nan Wang  <n_wang@apple.com>
     2
     3        AX: VoiceOver on iOS ignores aria-checked on menuitemradio and menuitemcheckbox
     4        https://bugs.webkit.org/show_bug.cgi?id=161118
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Added checkboxOrRadioValue and toggle trait to menuitemradio and menuitemcheckbox.
     9
     10        Test: accessibility/ios-simulator/menuitem-checked.html
     11
     12        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
     13        (-[WebAccessibilityObjectWrapper accessibilityTraits]):
     14        (-[WebAccessibilityObjectWrapper accessibilityValue]):
     15
    1162016-08-24  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

    r204645 r204938  
    699699        case MenuButtonRole:
    700700        case MenuItemRole:
     701            traits |= [self _axMenuItemTrait];
     702            break;
    701703        case MenuItemCheckboxRole:
    702704        case MenuItemRadioRole:
    703             traits |= [self _axMenuItemTrait];
     705            traits |= ([self _axMenuItemTrait] | [self _axToggleTrait]);
    704706            break;
    705707        default:
    … …  
    12481250        return value;
    12491251   
    1250     if (m_object->isCheckboxOrRadio()) {
     1252    AccessibilityRole role = m_object->roleValue();
     1253    if (m_object->isCheckboxOrRadio() || role == MenuItemCheckboxRole || role == MenuItemRadioRole) {
    12511254        switch (m_object->checkboxOrRadioValue()) {
    12521255        case ButtonStateOff:
Note: See TracChangeset for help on using the changeset viewer.