Changeset 205018 in webkit
- Timestamp:
- Aug 26, 2016 9:41:48 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r205013 r205018 1 2016-08-26 Frederic Wang <fwang@igalia.com> 2 3 The annotation-xml element does not need to be behave as an mrow 4 https://bugs.webkit.org/show_bug.cgi?id=161230 5 6 Reviewed by Manuel Rego Casasnovas. 7 8 * platform/efl/accessibility/math-foreign-content-expected.txt: Remove the AXGroup from the 9 test expectation, which that was used for annotation-xml. 10 * platform/gtk/accessibility/math-foreign-content-expected.txt: Ditto. 11 * platform/mac/accessibility/math-foreign-content-expected.txt: Ditto. 12 1 13 2016-08-26 Alexey Proskuryakov <ap@apple.com> 2 14 -
trunk/LayoutTests/platform/efl/accessibility/math-foreign-content-expected.txt
r202552 r205018 6 6 AXRole: AXMath 7 7 AXRole: AXGroup 8 AXRole: AXGroup 9 AXRole: AXSection AXValue: SVG 8 AXRole: AXSection AXValue: SVG 10 9 AXRole: AXStatic AXValue: HTML 11 10 PASS successfullyParsed is true -
trunk/LayoutTests/platform/gtk/accessibility/math-foreign-content-expected.txt
r202497 r205018 6 6 AXRole: AXMath 7 7 AXRole: AXGroup 8 AXRole: AXGroup 9 AXRole: AXSection AXValue: SVG 8 AXRole: AXSection AXValue: SVG 10 9 AXRole: AXStatic AXValue: HTML 11 10 PASS successfullyParsed is true -
trunk/LayoutTests/platform/mac/accessibility/math-foreign-content-expected.txt
r202497 r205018 6 6 AXRole: AXGroup AXSubrole: AXDocumentMath AXValue: 7 7 AXRole: AXGroup AXSubrole: AXMathRow AXValue: 8 AXRole: AXGroup AXSubrole: AXMathRow AXValue: 9 AXRole: AXGroup AXSubrole: AXValue: 10 AXRole: AXStaticText AXSubrole: AXValue: SVG 8 AXRole: AXGroup AXSubrole: AXValue: 9 AXRole: AXStaticText AXSubrole: AXValue: SVG 11 10 AXRole: AXGroup AXSubrole: AXMathText AXValue: 12 11 AXRole: AXStaticText AXSubrole: AXValue: HTML -
trunk/Source/WebCore/ChangeLog
r205015 r205018 1 2016-08-26 Frederic Wang <fwang@igalia.com> 2 3 The annotation-xml element does not need to be behave as an mrow 4 https://bugs.webkit.org/show_bug.cgi?id=161230 5 6 Reviewed by Manuel Rego Casasnovas. 7 8 In r204779, MathMLAnnotationElement was made a MathMLRowElement just because the 9 annotation-xml element is generating a RenderMathMLRow. This later point is actually not 10 needed since annotation-xml is just a wrapper for foreign elements and so does not need to 11 handle special MathML features like operator spacing or stretching. We can thus move back 12 MathMLAnnotationElement to a generic MathMLPresentationElement and instead make the 13 annotation-xml element generate a generic RenderMathMLBlock renderer. 14 15 No new tests, semantics annotations already covered by existing tests. 16 17 * mathml/MathMLAnnotationElement.cpp: Replace RenderMathMLRow.h with RenderMathMLBlock.h 18 (WebCore::MathMLAnnotationElement::MathMLAnnotationElement): Inherit from 19 MathMLPresentationElement instead of MathMLRowElement. 20 (WebCore::MathMLAnnotationElement::createElementRenderer): Make annotation-xml create a 21 RenderMathMLBlock instead of a RenderMathMLRow. 22 (WebCore::MathMLAnnotationElement::attributeChanged): Inherit from MathMLPresentationElement 23 instead of MathMLRowElement. 24 * mathml/MathMLAnnotationElement.h: Ditto. 25 1 26 2016-08-26 Csaba Osztrogonác <ossy@webkit.org> 2 27 -
trunk/Source/WebCore/mathml/MathMLAnnotationElement.cpp
r204885 r205018 34 34 #include "MathMLNames.h" 35 35 #include "MathMLSelectElement.h" 36 #include "RenderMathML Row.h"36 #include "RenderMathMLBlock.h" 37 37 #include "SVGSVGElement.h" 38 38 … … 42 42 43 43 MathMLAnnotationElement::MathMLAnnotationElement(const QualifiedName& tagName, Document& document) 44 : MathML RowElement(tagName, document)44 : MathMLPresentationElement(tagName, document) 45 45 { 46 46 ASSERT(hasTagName(annotationTag) || hasTagName(annotation_xmlTag)); … … 57 57 return MathMLElement::createElementRenderer(WTFMove(style), insertionPosition); 58 58 59 // FIXME: Do we really need to create a RenderMathMLRow?60 59 ASSERT(hasTagName(annotation_xmlTag)); 61 return createRenderer<RenderMathML Row>(*this, WTFMove(style));60 return createRenderer<RenderMathMLBlock>(*this, WTFMove(style)); 62 61 } 63 62 … … 101 100 downcast<MathMLElement>(*parent).updateSelectedChild(); 102 101 } 103 MathML RowElement::attributeChanged(name, oldValue, newValue, reason);102 MathMLPresentationElement::attributeChanged(name, oldValue, newValue, reason); 104 103 } 105 104 -
trunk/Source/WebCore/mathml/MathMLAnnotationElement.h
r204885 r205018 28 28 #if ENABLE(MATHML) 29 29 30 #include "MathML RowElement.h"30 #include "MathMLPresentationElement.h" 31 31 32 32 namespace WebCore { 33 33 34 class MathMLAnnotationElement final : public MathML RowElement {34 class MathMLAnnotationElement final : public MathMLPresentationElement { 35 35 public: 36 36 static Ref<MathMLAnnotationElement> create(const QualifiedName& tagName, Document&);
Note: See TracChangeset
for help on using the changeset viewer.