Changeset 205090 in webkit

Timestamp:

Aug 27, 2016 5:14:22 PM (8 years ago)

Author:

pvollan@apple.com

Message:

[Win] Enable 'warning as error' compiler setting.
​https://bugs.webkit.org/show_bug.cgi?id=161243

Reviewed by Darin Adler.

• Source/cmake/OptionsWin.cmake:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/OptionsWin.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2016-08-27  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] Enable 'warning as error' compiler setting.
+        https://bugs.webkit.org/show_bug.cgi?id=161243
+
+        Reviewed by Darin Adler.
+
+        * Source/cmake/OptionsWin.cmake:
+
 2016-08-26  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/cmake/OptionsWin.cmake

@@ -123 +123 @@
     add_definitions(
         /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189
-        /wd4201 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309
-        /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481
-        /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702
-        /wd4706 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211
-        /wd6246 /wd6255 /wd6387
+        /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305
+        /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459
+        /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646
+        /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011
+        /wd6031 /wd6211 /wd6246 /wd6255 /wd6387
     )
 
     # Create pdb files for debugging purposes, also for Release builds
     add_compile_options(/Zi /GS)
+
+    # Warnings as errors (ignore narrowing conversions)
+    add_compile_options(/WX /Wv:18)
 
     set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DEBUG /OPT:ICF /OPT:REF")