Changeset 205128 in webkit


Ignore:
Timestamp:
Aug 29, 2016 11:26:52 AM (8 years ago)
Author:
achristensen@apple.com
Message:

API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=161317

Reviewed by Brady Eidson.

Source/WebCore:

Added an API test.

  • platform/URLParser.cpp:

(WebCore::URLParser::parse):
Turns out, this state can be reached.

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r205117 r205128  
     12016-08-29  Alex Christensen  <achristensen@webkit.org>
     2
     3        API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
     4        https://bugs.webkit.org/show_bug.cgi?id=161317
     5
     6        Reviewed by Brady Eidson.
     7
     8        Added an API test.
     9
     10        * platform/URLParser.cpp:
     11        (WebCore::URLParser::parse):
     12        Turns out, this state can be reached.
     13
    1142016-08-29  Youenn Fablet  <youenn@apple.com>
    215
  • trunk/Source/WebCore/platform/URLParser.cpp

    r205097 r205128  
    429429    case State::SchemeStart:
    430430        LOG_FINAL_STATE("SchemeStart");
    431         ASSERT_NOT_REACHED();
    432431        return { };
    433432    case State::Scheme:
  • trunk/Tools/ChangeLog

    r205127 r205128  
     12016-08-29  Alex Christensen  <achristensen@webkit.org>
     2
     3        API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
     4        https://bugs.webkit.org/show_bug.cgi?id=161317
     5
     6        Reviewed by Brady Eidson.
     7
     8        * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
     9        (TestWebKitAPI::TEST_F):
     10
    1112016-08-29  Jer Noble  <jer.noble@apple.com>
    212
  • trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp

    r205097 r205128  
    181181{
    182182    shouldFail("    ");
     183    shouldFail("");
    183184}
    184185
Note: See TracChangeset for help on using the changeset viewer.