Changeset 205204 in webkit


Ignore:
Timestamp:
Aug 30, 2016 3:43:12 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

[JSC] Clean up the remaining compare nodes in FTLCapabilities
​https://bugs.webkit.org/show_bug.cgi?id=161400

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-08-30
Reviewed by Geoffrey Garen.

It looks like we implemented all the cases without realizing it.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compare):

Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r205198 r205204  
     12016-08-30  Benjamin Poulain  <bpoulain@apple.com>
     2
     3        [JSC] Clean up the remaining compare nodes in FTLCapabilities
     4        https://bugs.webkit.org/show_bug.cgi?id=161400
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        It looks like we implemented all the cases without realizing it.
     9
     10        * ftl/FTLCapabilities.cpp:
     11        (JSC::FTL::canCompile):
     12        * ftl/FTLLowerDFGToB3.cpp:
     13        (JSC::FTL::DFG::LowerDFGToB3::compare):
     14
    1152016-08-30  Mark Lam  <mark.lam@apple.com>
    216

  • trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp

    r205166 r205204  
    248248    case CompareEq:
    249249    case CompareEqPtr:
     250    case CompareLess:
     251    case CompareLessEq:
     252    case CompareGreater:
     253    case CompareGreaterEq:
    250254    case CompareStrictEq:
    251255        // These are OK.
    … …  
    365369        }
    366370        break;
    367     case CompareLess:
    368     case CompareLessEq:
    369     case CompareGreater:
    370     case CompareGreaterEq:
    371         if (node->isBinaryUseKind(Int32Use))
    372             break;
    373         if (node->isBinaryUseKind(Int52RepUse))
    374             break;
    375         if (node->isBinaryUseKind(DoubleRepUse))
    376             break;
    377         if (node->isBinaryUseKind(StringIdentUse))
    378             break;
    379         if (node->isBinaryUseKind(StringUse))
    380             break;
    381         if (node->isBinaryUseKind(UntypedUse))
    382             break;
    383         return CannotCompile;
    384371    default:
    385372        // Don't know how to handle anything else.

  • trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

    r205166 r205204  
    80908090        }
    80918091
    8092         if (m_node->isBinaryUseKind(UntypedUse)) {
    8093             nonSpeculativeCompare(intFunctor, fallbackFunction);
    8094             return;
    8095         }
    8096        
    8097         DFG_CRASH(m_graph, m_node, "Bad use kinds");
     8092        DFG_ASSERT(m_graph, m_node, m_node->isBinaryUseKind(UntypedUse));
     8093        nonSpeculativeCompare(intFunctor, fallbackFunction);
    80988094    }
    80998095
Note: See TracChangeset for help on using the changeset viewer.