Changeset 205246 in webkit

Timestamp:

Aug 31, 2016 2:12:25 AM (8 years ago)

Author:

Antti Koivisto

Message:

REGRESSION (r201701): Unable to copy from CodeMirror editor version used in Jenkins install website
​https://bugs.webkit.org/show_bug.cgi?id=161386
<rdar://problem/27590077>

Reviewed by Dan Bernstein.

Source/WebCore:

This CodeMirror version uses a hidden <textarea> to implement copy/paste. The textarea has width:1px; border-width:1px.
Jenkins page has also has a stylesheet that contains * { box-sizing:border-box } and as a result the textarea content
width gets computed as 0. With r201701 we use content size instead of box size for clipping and the textarea content is
(correctly) considered invisible.

Add a quirk that allows this to continue working.

Test: editing/text-iterator/hidden-textarea-selection-quirk.html

• editing/TextIterator.cpp:

(WebCore::fullyClipsContents):

LayoutTests:

• editing/text-iterator/hidden-textarea-selection-quirk-expected.txt: Added.
• editing/text-iterator/hidden-textarea-selection-quirk.html: Added.
• platform/ios-simulator/editing/text-iterator/hidden-textarea-selection-quirk-expected.txt: Added.

textarea.select() doesn't select the text content on iOS.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/text-iterator/hidden-textarea-selection-quirk-expected.txt (added)
• LayoutTests/editing/text-iterator/hidden-textarea-selection-quirk.html (added)
• LayoutTests/platform/ios-simulator/editing/text-iterator (added)
• LayoutTests/platform/ios-simulator/editing/text-iterator/hidden-textarea-selection-quirk-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/TextIterator.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-08-31  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (r201701): Unable to copy from CodeMirror editor version used in Jenkins install website
+        https://bugs.webkit.org/show_bug.cgi?id=161386
+        <rdar://problem/27590077>
+
+        Reviewed by Dan Bernstein.
+
+        * editing/text-iterator/hidden-textarea-selection-quirk-expected.txt: Added.
+        * editing/text-iterator/hidden-textarea-selection-quirk.html: Added.
+        * platform/ios-simulator/editing/text-iterator/hidden-textarea-selection-quirk-expected.txt: Added.
+
+            textarea.select() doesn't select the text content on iOS.
+
 2016-08-30  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-08-31  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (r201701): Unable to copy from CodeMirror editor version used in Jenkins install website
+        https://bugs.webkit.org/show_bug.cgi?id=161386
+        <rdar://problem/27590077>
+
+        Reviewed by Dan Bernstein.
+
+        This CodeMirror version uses a hidden <textarea> to implement copy/paste. The textarea has width:1px; border-width:1px.
+        Jenkins page has also has a stylesheet that contains * { box-sizing:border-box } and as a result the textarea content
+        width gets computed as 0. With r201701 we use content size instead of box size for clipping and the textarea content is
+        (correctly) considered invisible.
+
+        Add a quirk that allows this to continue working.
+
+        Test: editing/text-iterator/hidden-textarea-selection-quirk.html
+
+        * editing/TextIterator.cpp:
+        (WebCore::fullyClipsContents):
+
 2016-08-31  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/editing/TextIterator.cpp

@@ -41 +41 @@
 #include "HTMLParagraphElement.h"
 #include "HTMLProgressElement.h"
+#include "HTMLTextAreaElement.h"
 #include "HTMLTextFormControlElement.h"
 #include "InlineTextBox.h"
@@ -214 +215 @@
     if (!box.hasOverflowClip())
         return false;
+
+    // Quirk to keep copy/paste in the CodeMirror editor version used in Jenkins working.
+    if (is<HTMLTextAreaElement>(node))
+        return box.size().isEmpty();
+
     return box.contentSize().isEmpty();
 }