Changeset 205362 in webkit

Timestamp:

Sep 2, 2016 12:39:02 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

bitwise_cast infinite loops if called from the default constructor in ToType
​https://bugs.webkit.org/show_bug.cgi?id=161365

Patch by JF Bastien <​jfbastien@apple.com> on 2016-09-02
Reviewed by Saam Barati.

• wtf/StdLibExtras.h:

(WTF::bitwise_cast): use aggregate initialization to avoid ctor

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/StdLibExtras.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2016-09-02  JF Bastien  <jfbastien@apple.com>
+
+        bitwise_cast infinite loops if called from the default constructor in ToType
+        https://bugs.webkit.org/show_bug.cgi?id=161365
+
+        Reviewed by Saam Barati.
+
+        * wtf/StdLibExtras.h:
+        (WTF::bitwise_cast): use aggregate initialization to avoid ctor
+
 2016-09-01  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WTF/wtf/StdLibExtras.h

@@ -152 +152 @@
     static_assert(__is_trivially_copyable(FromType), "bitwise_cast of non-trivially-copyable type!");
 #endif
-    ToType to;
+    ToType to{ };
     std::memcpy(&to, &from, sizeof(to));
     return to;