Changeset 205377 in webkit

Timestamp:

Sep 2, 2016 3:42:32 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[Mac] RetainPtr misuse, DDActionContext leaks
​https://bugs.webkit.org/show_bug.cgi?id=161551

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-09-02
Reviewed by Tim Horton.

• Platform/mac/MenuUtilities.mm:

(WebKit::menuItemForTelephoneNumber):
(WebKit::menuForTelephoneNumber):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/mac/MenuUtilities.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [Mac] RetainPtr misuse, DDActionContext leaks
+        https://bugs.webkit.org/show_bug.cgi?id=161551
+
+        Reviewed by Tim Horton.
+
+        * Platform/mac/MenuUtilities.mm:
+        (WebKit::menuItemForTelephoneNumber):
+        (WebKit::menuForTelephoneNumber):
+
 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebKit2/Platform/mac/MenuUtilities.mm

@@ -54 +54 @@
         return nil;
 
-    RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init];
+    RetainPtr<DDActionContext> actionContext = adoptNS([[getDDActionContextClass() alloc] init]);
     [actionContext setAllowedActionUTIs:@[ @"com.apple.dial" ]];
 
@@ -85 +85 @@
     NSMenuItem *dialItem = nil;
 
-    RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init];
+    RetainPtr<DDActionContext> actionContext = adoptNS([[getDDActionContextClass() alloc] init]);
     [actionContext setAllowedActionUTIs:@[ @"com.apple.dial", @"com.apple.facetime", @"com.apple.facetimeaudio" ]];