Changeset 205378 in webkit


Ignore:
Timestamp:
Sep 2, 2016 3:44:15 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

[Mac] RetainPtr misuse, AnimationController leaks
https://bugs.webkit.org/show_bug.cgi?id=161552

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-09-02
Reviewed by Tim Horton.

Source/WebKit/mac:

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _defaultAnimationController]):

Source/WebKit2:

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _defaultAnimationController]):

Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/mac/ChangeLog

    r205365 r205378  
     12016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        [Mac] RetainPtr misuse, AnimationController leaks
     4        https://bugs.webkit.org/show_bug.cgi?id=161552
     5
     6        Reviewed by Tim Horton.
     7
     8        * WebView/WebImmediateActionController.mm:
     9        (-[WebImmediateActionController _defaultAnimationController]):
     10
    1112016-07-08  Jer Noble  <jer.noble@apple.com>
    212
  • trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm

    r202524 r205378  
    6464@end
    6565
    66 @interface WebAnimationController : NSObject <NSImmediateActionAnimationController> {
    67 }
     66@interface WebAnimationController : NSObject <NSImmediateActionAnimationController>
    6867@end
    6968
     
    258257{
    259258    if (_contentPreventsDefault) {
    260         RetainPtr<WebAnimationController> dummyController = [[WebAnimationController alloc] init];
    261         return dummyController.get();
     259        RetainPtr<WebAnimationController> dummyController = adoptNS([[WebAnimationController alloc] init]);
     260        return dummyController.autorelease();
    262261    }
    263262
  • trunk/Source/WebKit2/ChangeLog

    r205377 r205378  
     12016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        [Mac] RetainPtr misuse, AnimationController leaks
     4        https://bugs.webkit.org/show_bug.cgi?id=161552
     5
     6        Reviewed by Tim Horton.
     7
     8        * UIProcess/mac/WKImmediateActionController.mm:
     9        (-[WKImmediateActionController _defaultAnimationController]):
     10
    1112016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
    212
  • trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm

    r202242 r205378  
    5656@end
    5757
    58 @interface WKAnimationController : NSObject <NSImmediateActionAnimationController> {
    59 }
     58@interface WKAnimationController : NSObject <NSImmediateActionAnimationController>
    6059@end
    6160
     
    272271{
    273272    if (_contentPreventsDefault) {
    274         RetainPtr<WKAnimationController> dummyController = [[WKAnimationController alloc] init];
    275         return dummyController.get();
     273        RetainPtr<WKAnimationController> dummyController = adoptNS([[WKAnimationController alloc] init]);
     274        return dummyController.autorelease();
    276275    }
    277276
Note: See TracChangeset for help on using the changeset viewer.